From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= <devrim@gunduz.org>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: drop support for Python 2.3
In-reply-to: <664e0d02-20ed-5ae8-7d60-8f779d759072@2ndquadrant.com>
References: <7d5073f6-d9ea-ab09-4805-69a12f23e52f@2ndquadrant.com>
 <9516.1486529343@sss.pgh.pa.us>
 <adb38a71-0aa7-087d-2791-4987f3026244@2ndquadrant.com>
 <1486568115.5462.50.camel@gunduz.org>
 <0e2fd256-0a3a-bae8-4ef2-c536139c64cb@2ndquadrant.com>
 <1487493740.2748.13.camel@gunduz.org> <797.1487517822@sss.pgh.pa.us>
 <1453.1487518921@sss.pgh.pa.us> <1487527748.2748.37.camel@gunduz.org>
 <24334.1487530091@sss.pgh.pa.us> <1487535029.3796.1.camel@gunduz.org>
 <633.1487539228@sss.pgh.pa.us> <1487565212.4910.3.camel@gunduz.org>
 <664e0d02-20ed-5ae8-7d60-8f779d759072@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Tue, 21 Feb 2017 09:51:04 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <7164.1487690305.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Tue, 21 Feb 2017 10:18:25 -0500
Message-ID: <7165.1487690305@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2/19/17 23:33, Devrim Gündüz wrote:
>> Thanks! Looks like buildfarm is green again.

> Thank.  I have committed the patch to drop Python 2.3 support.

I spent some time last night building a (rather makeshift) python 2.4.1
installation on prairiedog, which I will now switch it to use in HEAD,
but keeping it pointed at 2.3 for 9.6 and older.

Based on some not-fun I had along the way to that, I think it would be
a good idea to do the Python version check a bit earlier than you have
here.  The shlib search in PGAC_CHECK_PYTHON_EMBED_SETUP is pretty fragile
and version-dependent, which means that a person could waste a lot of time
trying to get past the "could not find shared library for Python" error
before being told that their Python is too old.  I propose to move the
minimum-version check into _PGAC_CHECK_PYTHON_DIRS, say right after the
[Python configuration directory] stanza.  Unless there was some specific
reason for not wanting it to happen in python.m4?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers