From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
cc: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Getting ERROR: could not open file "base/13164/t3_16388" with
 partition table with ON COMMIT
In-reply-to: <2bf804fb-7417-4539-51c5-f6419f1e8741@lab.ntt.co.jp>
References: 
 <CAKcux6mhgcjSiB_egqEAEFgX462QZtncU8QCAJ2HZwM-wWGVew@mail.gmail.com>
 <2bf804fb-7417-4539-51c5-f6419f1e8741@lab.ntt.co.jp>
Comments: In-reply-to Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
	message dated "Wed, 12 Sep 2018 19:53:39 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7192.1536768840.1@sss.pgh.pa.us>
Date: Wed, 12 Sep 2018 12:14:00 -0400
Message-ID: <7193.1536768840@sss.pgh.pa.us>
Precedence: bulk

Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
> The infamous missing-relkind-check in heap_truncate() seems to be behind
> this.  Perhaps, a patch like the attached will do?

That seems excessively restrictive.  Anything that has storage (e.g.
matviews) ought to be truncatable, no?

I thought we had a macro or utility function somewhere that knew which
relkinds have storage, though I can't find it right now.  I'd be
inclined to instantiate that if it doesn't exist, and then the code
here ought to read something like

	if (RelkindHasStorage(rel->rd_rel->relkind))
		heap_truncate_one_rel(rel);

Also, possibly the test ought to be inside heap_truncate_one_rel
rather than its callers?

			regards, tom lane