Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: pg_amcheck contrib application
From: Mark Dilger <mark.dilger@enterprisedb.com>
In-Reply-To: 
 <CA+TgmobnhjZaHeEweRpznx5g+udJcq9a9izn53OaCPwvZS6mag@mail.gmail.com>
Date: Fri, 30 Apr 2021 13:04:24 -0700
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 Noah Misch <noah@leadboat.com>,
 Peter Geoghegan <pg@bowt.ie>,
 Thomas Munro <thomas.munro@gmail.com>,
 "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
 Stephen Frost <sfrost@snowman.net>,
 Michael Paquier <michael@paquier.xyz>,
 Amul Sul <sulamul@gmail.com>,
 Dilip Kumar <dilipbalaut@gmail.com>,
 Andres Freund <andres@anarazel.de>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <71C96F66-2FC5-4F45-BFBA-2AB91AF091B1@enterprisedb.com>
References: 
 <CAH2-WzmZJ3MWjaSEaysmkP8A7WL_TiCwOS8eT88yc-bwHgLOKg@mail.gmail.com>
 <CAH2-WznpwULZ3uJ1_6WXvNMXYbOy8k8tYs3r=qSdGmZeRd6tDw@mail.gmail.com>
 <CA+TgmoZUJ4j31CbnUz-DpBBq_DVoaYcuG5XB7hP71+uQ=js_KQ@mail.gmail.com>
 <CA+TgmoZ1DP0pkLyuG9y7Jtn2v7N-+dnVxbvBAT__u4-d=UYmbw@mail.gmail.com>
 <A80D68F6-E38F-482D-9522-E2FB6AAFE8A1@enterprisedb.com>
 <CA+TgmoY3_U=QuQWo4DArBSp+tg2MiCHLwDN_9U2H_iTxj3UcjA@mail.gmail.com>
 <9E76E46A-48B2-4869-BD0C-422204C1F767@enterprisedb.com>
 <F0A1FD70-A2F4-4528-8A03-8650CAEC0554@enterprisedb.com>
 <20210313184612.GA3195145@rfd.leadboat.com>
 <930621E5-5D10-456D-8CE4-CF629A6C4669@enterprisedb.com>
 <20210313191841.GB3195145@rfd.leadboat.com>
 <3012106.1615827854@sss.pgh.pa.us>
 <C2C142F3-F740-4197-B507-20B28B7395AC@enterprisedb.com>
 <3053552.1615834640@sss.pgh.pa.us>
 <AA5506CE-7D2A-42E4-A51D-358635E3722D@enterprisedb.com>
 <CA+TgmoYAi_3_sCnsH2qwVFW1WUGqn3xOcGWjjvDtn4j4xfso+A@mail.gmail.com>
 <4F10540A-9022-49EE-A6FC-7FE90797793E@enterprisedb.com>
 <0D48534A-F511-405D-8645-84B0A1DA1E11@enterprisedb.com>
 <CA+TgmoaA88XCjuFmzWnMh0fTcEWF_TWuXmzSAB0xKfXy84Fp3w@mail.gmail.com>
 <CA+TgmobA_x0A1jh+V=vD1mHB+pzFaR2wTzng4yoKzgr_hvNOcg@mail.gmail.com>
 <CA+Tgmoaq7PoO8XCRgaM3t43yer2bUc8Kt6ZsvE6wYtLPCTRsOA@mail.gmail.com>
 <F42DEB1D-A3A9-4C6F-97D6-4B4C0ADAEF6C@enterprisedb.com>
 <CA+TgmoZ3dkrFvtOraGgbH_uVQVjoOWQpmFDzq_EmcgmYwSfoPg@mail.gmail.com>
 <6915B9B2-B551-4DBC-89DB-C12D9AF985B8@enterprisedb.com>
 <CA+TgmoaHzOuFUzYKZ3rwJqJOOPH3P2c+M4AtLJeORpPdXBoTeA@mail.gmail.com>
 <B88086A1-9A46-437E-9083-9077259E992E@enterprisedb.com>
 <CA+Tgmob6sii0yTvULYJ0Vq4w6ZBmj7zUhddL3b+SKDi9z9NA7Q@mail.gmail.com>
 <FCF74E43-318E-44C4-92E0-D03AB07588F3@enterprisedb.com>
 <CA+TgmoZzy_Gn-3yh_iGiTz7dWWM0MmytKEFv5HoJWLko0cEVqA@mail.gmail.com>
 <23192440-3B8A-4D82-8C24-9D8161BAAB01@enterprisedb.com>
 <CA+TgmoYqfGfC-3=XajtV1BUZc3uKCgy0D5Mc0gz50V384unZqA@mail.gmail.com>
 <1F1A6246-854F-47F0-A179-A3CD9F05356B@enterprisedb.com>
 <CA+TgmoaUf5Yq+jN+rJdhSe+G4kzQywTk-LYmsPnCpTZZyZSVrg@mail.gmail.com>
 <CA+TgmobpeiMh7Y+vve7eRv8Rru=7FJ_Z2nM8EMxew+sWBr58Og@mail.gmail.com>
 <AC5479E4-6321-473D-AC92-5EC36299FBC2@enterprisedb.com>
 <CA+TgmoYw5YjGRt3hjg3XdZQ4rNnSB22JVdRO9SGE+MfjZayGZQ@mail.gmail.com>
 <E4F162F1-0DF4-4919-BD75-AF73F125D1E8@enterprisedb.com>
 <CA+Tgmob88VSOSUxn2M=ajT0TrVF8KrLQtGBpUAEP2=geNSHJQw@mail.gmail.com>
 <EA725232-2D5E-46CF-AC37-B702E2286454@enterprisedb.com>
 <CA+TgmoZG+k_8d-LmpVV6-yhpu5r0sVvRAUBu_pZC9ZBMs5jBPg@mail.gmail.com>
 <50DA1F9A-D6AB-40DE-AB24-E8BDC13F4DA1@enterprisedb.com>
 <CA+Tgmob=vyOn=iQRd18Y=EDXC8-KtUUXbznGKjFdhOBmuaP-rg@mail.gmail.com>
 <7D3B9BF6-50D0-4C30-8506-1C1851C7F96F@enterprisedb.com>
 <CA+TgmoYYG8EDQu9nMzuR6hfM0WQ7DrEQ2zG+gBKTEedZLDtP4A@mail.gmail.com>
 <E2F90213-EF47-4170-ABCD-C1795D457059@enterprisedb.com>
 <CA+TgmoawwA4zJwUCJr9UcwPzivjjZS2nMB+YWm=0yACgsXTL+A@mail.gmail.com>
 <D443E2DC-B8AD-48A4-99D2-77CEDCF84AA0@enterprisedb.com>
 <98A8DC97-A585-44D8-9F79-B8232B8FABE3@enterprisedb.com>
 <CA+TgmoY0gsLca1s3_SxKSM=5Tzky7GS3bAyBdvioYtGNjHuheA@mail.gmail.com>
 <688D64BA-196B-42A1-8D56-645793EC252C@enterprisedb.com>
 <4DE07822-A9F5-4D76-9447-CE36C844534F@enterprisedb.com>
 <D93F111B-1279-435E-A162-AEF895BA4506@enterprisedb.com>
 <CA+TgmoYBfEaX0KaA6my6Ro3oKeZngKhN_V=TS2ygoS8nPoEwbQ@mail.gmail.com>
 <356632EB-924D-438C-A4AB-97A1CAF6B039@enterprisedb.com>
 <CA+TgmoapGYVYzb9nctO9+znsSafcsHBAf6bb2x_px8pT4aZe=A@mail.gmail.com>
 <D3828900-5183-4C67-8A13-8D58E54570AA@enterprisedb.com>
 <32D4C61A-8FD6-4C22-A62D-5594D5B4CCE6@enterprisedb.com>
 <CA+TgmoYjvN5JkABKtP-iVNp56A9jjwtHNzbpM5r0r4Noysy9Yw@mail.gmail.com>
 <91ED0048-C788-4540-B21F-6EBE622E9390@enterprisedb.com>
 <CA+TgmobmYWofcNX0iSrjyipp2K=jpPFZZMhZX_rnXJ2TnUemZQ@mail.gmail.com>
 <AB13E5D4-513F-4489-84B0-543EA5C4C2CD@enterprisedb.com>
 <CA+TgmoZUONCkdcdR778EKuE+f1r5Obieu63db2OgMPHaEvEPTQ@mail.gmail.com>
 <7A011F15-8C4D-49D5-9633-910A10A12F7B@enterprisedb.com>
 <CA+TgmobnhjZaHeEweRpznx5g+udJcq9a9izn53OaCPwvZS6mag@mail.gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/71C96F66-2FC5-4F45-BFBA-2AB91AF091B1%40enterprisedb.com>
Precedence: bulk


> On Apr 30, 2021, at 12:47 PM, Robert Haas <robertmhaas@gmail.com> =
wrote:
>=20
> Hmm, I think that might need adjustment, actually. What I was trying
> to do is compensate for the fact that what we now have is the next
> chunk_seq value we expect, not the last one we saw, nor the total
> number of chunks we've seen regardless of what chunk_seq they had. But
> I thought it would be too confusing to just give the chunk number we
> were expecting and not say anything about how many chunks we thought
> there would be in total. So maybe what I should do is change it to
> something like this:
>=20
> toast value %u was expected to end at chunk %d, but ended while
> expecting chunk %d
>=20
> i.e. same as the currently-committed code, except for changing "ended
> at" to "ended while expecting."

I find the grammar of this new formulation anomalous for hard to =
articulate reasons not quite the same as but akin to mismatched verb =
aspect.

=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company