Message-ID: <71b7dd2a-a47d-94a7-d677-961351dac85e@enterprisedb.com>
Date: Wed, 9 Mar 2022 11:35:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.2
Subject: Re: parse/analyze API refactoring
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: "Bossart, Nathan" <bossartn@amazon.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <c67ce276-52b4-0239-dc0e-39875bf81840@enterprisedb.com>
 <E684B0DB-2A23-4E02-80F1-C54D3856E0E6@amazon.com>
 <72519c4f-ebd8-b796-8216-1e6213fc1cf1@enterprisedb.com>
 <20220228185121.GA944837@nathanxps13>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <20220228185121.GA944837@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/71b7dd2a-a47d-94a7-d677-961351dac85e%40enterprisedb.com>
Precedence: bulk

On 28.02.22 19:51, Nathan Bossart wrote:
> On Mon, Feb 28, 2022 at 07:46:40AM +0100, Peter Eisentraut wrote:
>> You set this commit fest entry to Waiting on Author, but there were no
>> reviews posted and the patch still applies and builds AFAICT, so I don't
>> know what you meant by that.
> 
> Apologies for the lack of clarity.  I believe my only feedback was around
> deduplicating the pg_analyze_and_rewrite_*() functions.  Would you rather
> handle that in a separate patch?

I have committed my original patches.  I'll leave the above-mentioned 
topic as ideas for the future.