From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Thomas Munro <thomas.munro@gmail.com>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL
In-reply-to: <20190522175150.c26f4jkqytahajdg@alap3.anarazel.de>
References: <5506b8fa-7dad-8483-053c-7ca7ef04f01a@2ndQuadrant.com>
 <20190521015840.cztw2qxthh7xuutk@alap3.anarazel.de>
 <aaee2cc8-d722-990c-b848-413ba9913703@2ndQuadrant.com>
 <20190521191918.z7kwnrlj45mk2k67@alap3.anarazel.de>
 <20190521194129.2kl2mldesrr65gmb@alap3.anarazel.de>
 <CA+hUKGKY=p7ZeZmAiC0zK72moLyYC=HaF-Fg36s+tNEAJD6R+g@mail.gmail.com>
 <7333.1558537134@sss.pgh.pa.us>
 <20190522175150.c26f4jkqytahajdg@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 22 May 2019 10:51:50 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7199.1558548407.1@sss.pgh.pa.us>
Date: Wed, 22 May 2019 14:06:47 -0400
Message-ID: <7200.1558548407@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> Seems what we need to fix the immediate issue is to ressurect:

> # We need to make it use psql from our temporary installation,
> # because otherwise the installcheck run below would try to
> # use psql from the proper installation directory, which might
> # be outdated or missing. But don't override anything else that's
> # already in EXTRA_REGRESS_OPTS.
> EXTRA_REGRESS_OPTS="$EXTRA_REGRESS_OPTS --bindir='$bindir'"
> export EXTRA_REGRESS_OPTS

> and put that into global scope.

Not sure about that last bit.  pg_upgrade has the issue of possibly
wanting to deal with 2 installations, unlike the rest of the tree,
so I'm not sure that fixing its problem means there's something we
need to change everywhere else.

(IOW, keep an eye on the cross-version-upgrade tests while
you mess with this...)

			regards, tom lane