From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: Haribabu Kommi <kommi.haribabu@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Windows warnings from VS 2017
In-reply-to: <bfa18917-9cfa-57ce-1806-043d478c9519@2ndQuadrant.com>
References: <f6488a36-4702-6d50-9fb4-fee10bb49497@2ndQuadrant.com>
 <8649.1505951694@sss.pgh.pa.us>
 <acf6b500-0f91-cb38-d76b-17b6de29a606@2ndQuadrant.com>
 <c8fc2cd2-584f-1bf7-8d4a-ae05db709ad2@2ndQuadrant.com>
 <CAJrrPGfJMmM3iSrxAqiSJfV8L=3KBQobK9Nhbsns2jGD+fQ==w@mail.gmail.com>
 <bfa18917-9cfa-57ce-1806-043d478c9519@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Thu, 21 Sep 2017 08:11:35 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7213.1506000631.1@sss.pgh.pa.us>
Date: Thu, 21 Sep 2017 09:30:31 -0400
Message-ID: <7214.1506000631@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> The speed of memset is hardly going to be the dominating factor in a
> 'CREATE DATABASE' command, so we could certainly afford to change to
> plain memset calls here.

Another thought is that it may be time for our decennial debate about
whether MemSet is worth the electrons it's printed on.  I continue to
think that any modern compiler+libc ought to do an equivalent or better
optimization given just a plain memset().  If that seems to be true
for recent MSVC, we could consider putting an #if into c.h to define
MemSet as just memset for MSVC.  Maybe later that could be extended
to other compilers.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers