Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oafu6-0002jl-Sr for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Sep 2022 16:15:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oafu5-0002xl-Ki for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Sep 2022 16:15:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oafu5-0002xa-B4 for pgsql-hackers@lists.postgresql.org; Tue, 20 Sep 2022 16:15:21 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oafu0-0002UT-2C for pgsql-hackers@postgresql.org; Tue, 20 Sep 2022 16:15:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28KGFDbG722833; Tue, 20 Sep 2022 12:15:13 -0400 From: Tom Lane To: Thomas Munro cc: pgsql-hackers Subject: Re: Tree-walker callbacks vs -Wdeprecated-non-prototype In-reply-to: <508012.1663611012@sss.pgh.pa.us> References: <1725174.1651449765@sss.pgh.pa.us> <3953550.1663376882@sss.pgh.pa.us> <208054.1663534665@sss.pgh.pa.us> <334554.1663596005@sss.pgh.pa.us> <508012.1663611012@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Mon, 19 Sep 2022 14:10:12 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <722831.1663690513.1@sss.pgh.pa.us> Date: Tue, 20 Sep 2022 12:15:13 -0400 Message-ID: <722832.1663690513@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > (That verbiage is from the gcc manual; clang seems to act the same > except that -Wcast-function-type is selected by -Wall, or perhaps is > even on by default.) Nah, scratch that: the reason -Wcast-function-type is on is that we explicitly enable it, and have done so since de8feb1f3 (v14). I did not happen to see this warning with gcc because the test runs I made with this patch already had c35ba141d, whereas I did my clang test on another machine that wasn't quite up to HEAD. So we should have good warning coverage for bogus walker signatures on both compilers. regards, tom lane