Message-ID: <7232d0e1-36af-bf3f-e784-6b5576bae627@pgmasters.net>
Date: Tue, 13 Jun 2023 09:44:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: Views no longer in rangeTabls?
To: Amit Langote <amitlangote09@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Julien Rouhaud <rjuju123@gmail.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>
References: <3953179e-9540-e5d1-a743-4bef368785b0@pgmasters.net>
 <CA+HiwqFC0xDCCiXbUjb-xisxo9PPuA8_ykn8Fz+6RbBJBE8mVA@mail.gmail.com>
 <462cd5de-3ade-989b-0798-7e1cab562991@pgmasters.net>
 <470644.1686327286@sss.pgh.pa.us>
 <edb0f313-648e-bbca-5ce0-225b9cce046d@pgmasters.net>
 <CA+HiwqFaMfM-082vwNYSAWU13T9nd62DObeNLbSTisSh6odOog@mail.gmail.com>
 <b8a0b834-c936-d135-df66-cc119ceb8205@pgmasters.net>
 <625519.1686401807@sss.pgh.pa.us> <20230610131857.cqrsm6pwq3k47yuv@jrouhaud>
 <629054.1686403658@sss.pgh.pa.us>
 <CA+HiwqF1CgsZKvBW_Gz9tErKfOp4t=PQgUKvrvWBG0HP8LdAXQ@mail.gmail.com>
Content-Language: en-US
From: David Steele <david@pgmasters.net>
In-Reply-To: <CA+HiwqF1CgsZKvBW_Gz9tErKfOp4t=PQgUKvrvWBG0HP8LdAXQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/7232d0e1-36af-bf3f-e784-6b5576bae627%40pgmasters.net>
Precedence: bulk

On 6/13/23 06:09, Amit Langote wrote:
> On Sat, Jun 10, 2023 at 10:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Julien Rouhaud <rjuju123@gmail.com> writes:
>>> On Sat, Jun 10, 2023 at 08:56:47AM -0400, Tom Lane wrote:
>>>> -   rte->relkind = 0;
>>
>>> and also handle that field in (read|out)funcs.c
>>
>> Oh, right.  Ugh, that means a catversion bump.  It's not like
>> we've never done that during beta, but it's kind of an annoying
>> cost for a detail as tiny as this.
> 
> OK, so how about the attached?

The patch looks good to me. I also tested it against pgAudit and 
everything worked. I decided to go with the following because I think it 
is easier to read:

/* We only care about tables/views and can ignore subqueries, etc. */
if (!(rte->rtekind == RTE_RELATION ||
       (rte->rtekind == RTE_SUBQUERY && rte->relkind == RELKIND_VIEW)))
     continue;

> I considered adding Assert(relkind == RELKIND_VIEW) in all places that
> have the "rte->rtekind == RTE_SUBQUERY && OidIsValid(rte->relid)"
> condition, but that seemed like an overkill, so only added one in the
> #ifdef USE_ASSERT_CHECKING block in ExecCheckPermissions() that
> f75cec4fff877 added.

This seems like a good place for the assert.

Thanks!
-David