Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1masD3-0003sJ-GO
	for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Oct 2021 04:19:13 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1masD2-0003qy-D0
	for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Oct 2021 04:19:12 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1masD2-0003qo-4h
	for pgsql-hackers@lists.postgresql.org; Thu, 14 Oct 2021 04:19:12 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1masD0-00073t-2m
	for pgsql-hackers@postgresql.org; Thu, 14 Oct 2021 04:19:11 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 19E4J6CX726659;
	Thu, 14 Oct 2021 00:19:06 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Edmund Horner <ejrh00@gmail.com>
cc: David Fetter <david@fetter.org>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: psql tab completion for SELECT
In-reply-to: 
 <CAMyN-kBmq+J4Eqh=MVDLhjOO077uQEkbQWfBHSNPGQAUuXG9fw@mail.gmail.com>
References: 
 <CAMyN-kB_xrU4iYdcF1j=tijgO1DSyjtb3j96O4UEj91XZrZcMg@mail.gmail.com>
 <CAMyN-kAtgYx7gshnhbrVu8cmcontrj2rV_hXMmZmfP4v2CrW7Q@mail.gmail.com>
 <20211008070123.GN18391@fetter.org>
 <CAMyN-kBmq+J4Eqh=MVDLhjOO077uQEkbQWfBHSNPGQAUuXG9fw@mail.gmail.com>
Comments: In-reply-to Edmund Horner <ejrh00@gmail.com>
	message dated "Thu, 14 Oct 2021 16:53:37 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <726657.1634185146.1@sss.pgh.pa.us>
Date: Thu, 14 Oct 2021 00:19:06 -0400
Message-ID: <726658.1634185146@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/726658.1634185146%40sss.pgh.pa.us>
Precedence: bulk

Edmund Horner <ejrh00@gmail.com> writes:
> On Fri, 8 Oct 2021 at 20:01, David Fetter <david@fetter.org> wrote:
>> What precisely is this supposed to do?

> The main patch 0001 was to add completion for "SELECT <tab>" using
> attributes, functions, and a couple of hard-coded options.

This sort of thing has been proposed a few times, but never made it to
commit, because there's basically no way to limit the completions to a
usefully small set of possibilities.  SQL wasn't designed to make this
easy :-(

> Regarding testing, I can't see any automated tests for tab completion.

src/bin/psql/t/010_tab_completion.pl

			regards, tom lane