public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chao Li <[email protected]>
To: Fujii Masao <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Date: Sat, 22 Nov 2025 09:31:06 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwGnkM8aYtxYAHXRPWYe90fbypz5TMezHDiy0Jt8=+BPpQ@mail.gmail.com>
References: <CAHGQGwGYV+-abbKwdrM2UHUe-JYOFWmsrs6=QicyJO-j+-Widw@mail.gmail.com>
	<[email protected]>
	<CAHGQGwGYG09DZnx7VVFvr7EfpC12sf+36D6iCSSAFMj66RY2_Q@mail.gmail.com>
	<[email protected]>
	<CAHGQGwGnkM8aYtxYAHXRPWYe90fbypz5TMezHDiy0Jt8=+BPpQ@mail.gmail.com>



> On Nov 22, 2025, at 00:14, Fujii Masao <[email protected]> wrote:
> 
> On Fri, Nov 21, 2025 at 6:24 PM Chao Li <[email protected]> wrote:
>> No, what I was thinking is that, we could combine the three set statement into one, like:
>> 
>> ```
>> Set a = 1; set b = 2; set c = 3;
>> ```
>> So that sends a single statement to publisher server, that reduces round-trip from 3 times to one time.
> 
> I see the point about combining the three SET commands to reduce round trips,
> but I think the current approach in the patch (i.e., issuing a separate
> SET command for each parameter) is sufficient. I still don't think
> the additional round trip during replication connection startup is
> a real concern. This approach is also consistent with what postgres_fdw
> and pg_dump already do.
> 

No problem. I don’t have a strong option here. I just saw you mentioned overhead of round trip and thought to improve. But I agree that overhead is tiny, not a real concern.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

view thread (37+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox