Message-ID: <72c7c2b5848da44caddfe0f20f6c7ebc7c0c6e60.camel@j-davis.com>
Subject: Re: Speed up ICU case conversion by using ucasemap_utf8To*()
From: Jeff Davis <pgsql@j-davis.com>
To: Andreas Karlsson <andreas@proxel.se>, pgsql-hackers
	 <pgsql-hackers@postgresql.org>
Date: Fri, 20 Dec 2024 11:24:04 -0800
In-Reply-To: <167986ff-afcf-4542-94c6-61ee8474e138@proxel.se>
References: <167986ff-afcf-4542-94c6-61ee8474e138@proxel.se>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/72c7c2b5848da44caddfe0f20f6c7ebc7c0c6e60.camel%40j-davis.com>
Precedence: bulk

On Fri, 2024-12-20 at 06:20 +0100, Andreas Karlsson wrote:
> SELECT count(upper) FROM (SELECT upper(('K=C3=A5lhuvud ' || i) COLLATE=
=20
> "sv-SE-x-icu") FROM generate_series(1, 1000000) i);
>=20
> master:=C2=A0 ~540 ms
> Patched: ~460 ms
> glibc:=C2=A0=C2=A0 ~410 ms

It looks like you are opening and closing the UCaseMap object each
time. Why not save it in pg_locale_t? That should speed it up even more
and hopefully beat libc.


Also, to support older ICU versions consistently, we need to fix up the
locale name to support "und"; cf. pg_ucol_open(). Perhaps factor out
that logic?

Regards,
	Jeff Davis