Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1n9GZW-0004CJ-SE
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jan 2022 01:12:35 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1n9GZU-0000sd-3h
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jan 2022 01:12:32 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tim@mcnamara.nz>)
	id 1n9GZS-0000sU-1u
	for pgsql-hackers@lists.postgresql.org; Mon, 17 Jan 2022 01:12:31 +0000
Received: from out1-smtp.messagingengine.com ([66.111.4.25])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tim@mcnamara.nz>)
	id 1n9GZK-0001j9-B1
	for pgsql-hackers@lists.postgresql.org; Mon, 17 Jan 2022 01:12:28 +0000
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
	by mailout.nyi.internal (Postfix) with ESMTP id C5FA65C00D2
	for <pgsql-hackers@lists.postgresql.org>; Sun, 16 Jan 2022 20:12:20 -0500 (EST)
Received: from imap48 ([10.202.2.98])
  by compute5.internal (MEProxy); Sun, 16 Jan 2022 20:12:20 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mcnamara.nz; h=
	mime-version:message-id:date:from:to:subject:content-type; s=
	fm2; bh=uPJuOaRbZm8EdKvu3IsVswxDYvjzis20viJFRwaxz88=; b=oVCr1OTT
	mLb/+JNpgjuogDbmwzexH3a7vR9p2dvrlMntRTLRwtXtZUoVPaKP1w/gl9quMF8+
	gYesHA5yOjApHu6n+nXqw2C+GrsnRB66t0RkMZs6PXMhPnSsUaj+AfH1uAoB32ao
	PVr7s7+mWSaVVnXOokdoQ1EM/qgX+49VvA19H4bz2j/UNLbu8R3/dE3jl4wVcwaE
	lhEObQ6aCckr0FGUBGXMbksKBpVGafjSQWMF3sEzrv8qPMrYv+k4eZCqpl9CmJPx
	OFAwPbMAngISOdZjlYI9aMj0c8YiCJaJ2AmEr6DFtfa3PdIbKGSx2YWMl5Zv+MHZ
	Kp6H5mPlTK4F+Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=content-type:date:from:message-id
	:mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender
	:x-me-sender:x-sasl-enc; s=fm1; bh=uPJuOaRbZm8EdKvu3IsVswxDYvjzi
	s20viJFRwaxz88=; b=ORIMHzyyU9fxZ53aHHLAzNJVczGOsG+uDVudqfd5SRjii
	CwjN7oSIqNtOdTQWr/ZW5njkB57GtzNy82NACJlDGlOzwOPzT3Kp9cwVyFZtXrLT
	nC5zv8Yq725pq5mbS+oMct4pqU6OM49KnagiX+oYvL/SwVmkWZxuR3tw3NjUKanD
	uZ4BdD8Yv1r5nvRPM+FymjBMsXjqMHztUa4j7YbwhykCbD+T1MiTRdWx2Afy8WI+
	Az89YwOHQBfNVOmk/Dco1Q42bxxDbtKu93Od5wZzTkRUMJ0nUcmsc7mPCP1b4w5B
	4GQqPQcFQLnwZpH+NZm8UuEBJkCrKyuU0psFdLGbQ==
X-ME-Sender: <xms:dMLkYdwNhOGxnysHaw-_Va2gZOWfQMOAR5JAtTzj_EfMQVoMqzzEcQ>
    <xme:dMLkYdSqc4AUpA3I_5ACA99bnm9vc4x7nDTb13tvb-b9-DjkPsmZbN0clbzNqK2zE
    ZciZhrQuAE1RIzMQv8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddtgdefvdcutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesthdtredtre
    ertdenucfhrhhomhepfdfvihhmucfotgfprghmrghrrgdfuceothhimhesmhgtnhgrmhgr
    rhgrrdhniieqnecuggftrfgrthhtvghrnhepuefgleejgffftdeguddvtdfhudekuedvue
    fhhfetfeevffegkeeifeegkeeuudeunecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdr
    ohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
    htihhmsehmtghnrghmrghrrgdrnhii
X-ME-Proxy: <xmx:dMLkYXWMiufQRzcKgkqsohhTqlAeZmnU3zwEFRLAfG5u8SBFqftfuA>
    <xmx:dMLkYfhX7kb2AjyjnECD07lRNf2i-6XuBp3SyNKgbKscs16Spuk3_A>
    <xmx:dMLkYfAIaLvJiNuE7STMxnrwMNnwtGbIbDNqYHVXgIYDtE2GPZajZQ>
    <xmx:dMLkYSPYvUfIsSEQd4Qi1kdoITySQv9SpsJSnNcMz0DajLNGY5-5Lg>
Received: by mailuser.nyi.internal (Postfix, from userid 501)
	id 35EA121E006E; Sun, 16 Jan 2022 20:12:20 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.5.0-alpha0-4569-g891f756243-fm-20220111.001-g891f7562
Mime-Version: 1.0
Message-Id: <730dae39-abaa-4140-893b-95d732fed003@www.fastmail.com>
Date: Mon, 17 Jan 2022 14:11:59 +1300
From: "Tim McNamara" <tim@mcnamara.nz>
To: pgsql-hackers@lists.postgresql.org
Subject: New developer papercut - Makefile references INSTALL
Content-Type: text/plain
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/730dae39-abaa-4140-893b-95d732fed003%40www.fastmail.com>
Precedence: bulk

Hello,

I encountered a minor road bump when checking out the pg source today. The Makefile's all target includes the following help message if GNUmakefile isn't available: 

  echo "You need to run the 'configure' program first. See the file"; \
  echo "'INSTALL' for installation instructions." ; \

After consulting README.git, it looks as though INSTALL isn't created unless the source is bundled into a release or snapshot tarball. I'm happy to submit a patch to update the wording, but wanted to check on the preferred approach.

Perhaps this would be sufficient?

  echo "You need to run the 'configure' program first. See the file"; \
  echo "'INSTALL' for installation instructions, or visit" ; \
  echo "<https://www.postgresql.org/docs/devel/installation.html>" ; \

-Tim