public inbox for [email protected]
help / color / mirror / Atom feedFrom: Xiangyu Liang <[email protected]>
To: [email protected]
Subject: Fix grammar in comment describing LP_DEAD hint safety
Date: Wed, 28 Jan 2026 14:20:32 +0800 (CST)
Message-ID: <[email protected]> (raw)
Hi Hackers,
I noticed a small grammar issue in a comment describing LP_DEAD hint
handling.
The sentence was missing the verb "is" in "whether it is safe to apply
LP_DEAD hints to the page later", which makes the comment grammatically
incorrect.
This patch fixes the comment only and does not change any behavior.
Regards,
Xiangyu Liang
Attachments:
[application/octet-stream] v1-0001-Fix-grammar-in-comment-describing-LP_DEAD-hint-sa.patch (1.1K, ../[email protected]/3-v1-0001-Fix-grammar-in-comment-describing-LP_DEAD-hint-sa.patch)
download | inline diff:
From 8ab0786ed2650c2132af6df6c3ee6c7f2001b24a Mon Sep 17 00:00:00 2001
From: Xiangyu Liang <[email protected]>
Date: Wed, 28 Jan 2026 13:55:49 +0800
Subject: [PATCH v1] Fix grammar in comment describing LP_DEAD hint safety
The comment was missing the verb "is" in the sentence describing
whether it is safe to apply LP_DEAD hints to a page.
Author: Xiangyu Liang <[email protected]>
---
src/backend/access/gist/gistget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/access/gist/gistget.c b/src/backend/access/gist/gistget.c
index 11b214eb99b..2ff08b4ddb6 100644
--- a/src/backend/access/gist/gistget.c
+++ b/src/backend/access/gist/gistget.c
@@ -401,7 +401,7 @@ gistScanPage(IndexScanDesc scan, GISTSearchItem *pageItem,
MemoryContextReset(so->pageDataCxt);
/*
- * We save the LSN of the page as we read it, so that we know whether it
+ * We save the LSN of the page as we read it, so that we know whether it is
* safe to apply LP_DEAD hints to the page later. This allows us to drop
* the pin for MVCC scans, which allows vacuum to avoid blocking.
*/
--
2.52.0.windows.1
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Fix grammar in comment describing LP_DEAD hint safety
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox