Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
To: Mark Dilger <hornschnorter@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
 Thomas Munro <thomas.munro@enterprisedb.com>,
 Adrien Nayrat <adrien.nayrat@dalibo.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>
References: <0938F717-F4A0-4568-83B4-80A19887EA25@gmail.com>
 <933aab0d-fd36-9494-e0eb-79ebc4f57ef5@2ndquadrant.com>
 <e410d526-ab5c-0ca3-672b-6a1876a42ea8@2ndquadrant.com>
 <7F76E900-9A20-4640-A431-83B0602C3213@gmail.com>
 <bd60f67c-b7c2-eab4-74d7-28d6bf7ff393@2ndquadrant.com>
 <ECA6477E-8E2D-48CA-835B-062D2B9C1E11@gmail.com>
 <0c41dd0a-78bc-2bbb-43a1-3f8993514240@2ndquadrant.com>
 <CAEepm=1v46WwH1TTxxJyTpB2nrLYzS+R-=bwy2==Zqw=2EmnaA@mail.gmail.com>
 <651d8a4d-bd9d-087d-e89c-893f8ab1f257@2ndquadrant.com>
 <2db97323-4967-9a9e-51ac-ac7db64f0922@2ndquadrant.com>
 <20180302032948.nlq5mike3626hmoc@alap3.anarazel.de>
 <8dd4c3c8-f75e-8a3f-5854-14819d391897@2ndquadrant.com>
 <ffc50b2a-7d85-b046-8fbc-b3549b52080b@2ndquadrant.com>
 <464684DD-2FC7-40E4-8B9C-1FEB9F0BC4D5@gmail.com>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Message-ID: <732eeed1-9eb5-1bbf-5400-3866119ded11@2ndquadrant.com>
Date: Sat, 10 Mar 2018 15:05:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <464684DD-2FC7-40E4-8B9C-1FEB9F0BC4D5@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 03/10/2018 02:08 PM, Mark Dilger wrote:
> 
>> On Mar 3, 2018, at 2:40 PM, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:
>>
>> An updated patch version, fixing the breakage caused by fd1a421fe6
>> twiddling with pg_proc.
> 
> Hi Tomas, thanks again for this most useful patch!
> 
> Perhaps this is intentional, but there seems to be a place in src/backend/parser/parse_utilcmd.c
> that is overlooked in your recent patch set.  The simplest fix would be:
> 

Yeah, this is consequence of 5564c11815486bdfe87eb46ebc7c070293fa6956,
which fixed a place we forgot to modify in pg10. Will fix.


thanks

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services