Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTShs-0005qm-ES for pgsql-hackers@arkaria.postgresql.org; Wed, 22 May 2019 14:59:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hTShq-0004Fc-Qr for pgsql-hackers@arkaria.postgresql.org; Wed, 22 May 2019 14:59:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTShq-0004FV-Eb for pgsql-hackers@lists.postgresql.org; Wed, 22 May 2019 14:59:02 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hTSho-0008J5-80 for pgsql-hackers@postgresql.org; Wed, 22 May 2019 14:59:01 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x4MEwsRB007334; Wed, 22 May 2019 10:58:54 -0400 From: Tom Lane To: Thomas Munro cc: Andres Freund , Andrew Dunstan , PostgreSQL-development Subject: Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL In-reply-to: References: <5506b8fa-7dad-8483-053c-7ca7ef04f01a@2ndQuadrant.com> <20190521015840.cztw2qxthh7xuutk@alap3.anarazel.de> <20190521191918.z7kwnrlj45mk2k67@alap3.anarazel.de> <20190521194129.2kl2mldesrr65gmb@alap3.anarazel.de> Comments: In-reply-to Thomas Munro message dated "Wed, 22 May 2019 21:26:01 +1200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7332.1558537134.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 22 May 2019 10:58:54 -0400 Message-ID: <7333.1558537134@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Thomas Munro writes: > After these commits (and Tom's commit "Un-break pg_upgrade regression > test."), cfbot broke: > sh: 1: /usr/local/pgsql/bin/psql: not found I can confirm that here: check-world passes as long as I've done "make install" beforehand ... but of course that should not be necessary. If I blow away the install tree, pg_upgrade's check fails at ../../../src/test/regress/pg_regress --inputdir=3D. --bindir=3D'/home/post= gres/testversion/bin' --port=3D54464 --dlpath=3D. --max-concurrent-test= s=3D20 --port=3D54464 --schedule=3D./parallel_schedule = (using postmaster on /tmp/pg_upgrade_check-Nitf3h, port 54464) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D dropping database "regression" = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D sh: /home/postgres/testversion/bin/psql: No such file or directory command failed: "/home/postgres/testversion/bin/psql" -X -c "DROP DATABASE= IF EXISTS \"regression\"" "postgres" pg_regress is being told the wrong --bindir, ie the final install location not the temp install. (More generally, should we rearrange the buildfarm test sequence so it doesn't run "make install" till after the tests that aren't supposed to require an installed tree?) regards, tom lane