Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pR1EQ-0001ZX-Fy
	for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Feb 2023 01:32:42 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pR1EO-0004Jn-LV
	for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Feb 2023 01:32:40 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pR1EO-0004JY-Bm
	for pgsql-hackers@lists.postgresql.org; Sun, 12 Feb 2023 01:32:40 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pR1EH-0008RD-W8
	for pgsql-hackers@lists.postgresql.org; Sun, 12 Feb 2023 01:32:39 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 31C1WUOt734491;
	Sat, 11 Feb 2023 20:32:30 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Importing pg_bsd_indent into our source tree
In-reply-to: <20230212004254.3lp22a7bpkcjo3y6@awork3.anarazel.de>
References: <20230209215532.oomwhj5jyggmciq7@awork3.anarazel.de>
 <20230209221450.bkuozhhzlgpupx4d@awork3.anarazel.de>
 <3966340.1675981162@sss.pgh.pa.us>
 <20230209231013.gjpxs4gapxjatc64@awork3.anarazel.de>
 <3972584.1675984746@sss.pgh.pa.us>
 <20230210000841.4chvtmr4gkrfsotb@awork3.anarazel.de>
 <3979957.1675988437@sss.pgh.pa.us>
 <20230210003555.kyhyqq3imgocs62k@awork3.anarazel.de>
 <3986263.1675989733@sss.pgh.pa.us> <718245.1676159640@sss.pgh.pa.us>
 <20230212004254.3lp22a7bpkcjo3y6@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 11 Feb 2023 16:42:54 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <734489.1676165550.1@sss.pgh.pa.us>
Date: Sat, 11 Feb 2023 20:32:30 -0500
Message-ID: <734490.1676165550@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/734490.1676165550%40sss.pgh.pa.us>
Precedence: bulk

Hmmm ... ci autoconf build is now happy, but the Windows run complains
that none of the output files match.  I'm betting that this is a
Windows-newline problem, since I now see that indent.c opens both the
input and output files in default (text) mode.  I'm inclined to
change it to open the output file in binary mode while leaving the
input in text, which should have the effect of stripping \r if it's
present.

			regards, tom lane