From: Tom Lane <tgl@sss.pgh.pa.us>
To: tushar <tushar.ahuja@enterprisedb.com>
cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade failed if view contain natural left join condition
In-reply-to: <98b283cd-6dda-5d3f-f8ac-87db8c76a3da@enterprisedb.com>
References: <98b283cd-6dda-5d3f-f8ac-87db8c76a3da@enterprisedb.com>
Comments: In-reply-to tushar <tushar.ahuja@enterprisedb.com>
	message dated "Thu, 20 Jul 2017 17:39:43 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7382.1500558803.1@sss.pgh.pa.us>
Date: Thu, 20 Jul 2017 09:53:23 -0400
Message-ID: <7383.1500558803@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

tushar <tushar.ahuja@enterprisedb.com> writes:
> postgres=# create table t(n int);
> CREATE TABLE
> postgres=# create table t1(a int);
> CREATE TABLE
> postgres=# create view ttt1 as SELECT e.n FROM t e NATURAL LEFT JOIN t1 d;
> CREATE VIEW

You realize of course that that's a pretty useless join definition.
Still, yes, we do need to reverse-list the view with correct syntax.
Probably t LEFT JOIN t1 ON TRUE would do it.

> I think -this issue should be there in the older branches as well but 
> not checked that.

[experiments]  Seems to be wrong back to 9.3.  Although I have a feeling
this might be a mistake in a back-patched bug fix, so that it'd depend
on which 9.3.x you looked at.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers