Feedback-ID: ie0a040ee:Fastmail
Message-ID: <73e2eca8-3459-4a3e-aa85-122eda2d47e1@eisentraut.org>
Date: Mon, 14 Oct 2024 12:05:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Missing deconstruct_array_builtin usage
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
References: <Zwi5g2GzlUX1NqxR@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAD21AoCERkwmttY44dqUw=m_9QCctu7W+p6B7w_VqxRJA1Qq_Q@mail.gmail.com>
 <Zwy2UK0yz2bbpyZp@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <Zwy2UK0yz2bbpyZp@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/73e2eca8-3459-4a3e-aa85-122eda2d47e1%40eisentraut.org>
Precedence: bulk

On 14.10.24 08:12, Bertrand Drouvot wrote:
>> It seems that src/backend/utils/adt/float.c file still has functions
>> that can use [de]construct_array_builtin(), for example
>> float8_combine(). I think it's an oversight of d746021de1.
> Thanks for looking at it.
> 
> Good catch, please find attached v2 taking care of those. I looked at the
> remaining [de]construct_array() usages and that looks ok to me.

This looks good to me.  I can't think of a reason why it was not 
included in the original patch.