Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oebHU-0003mE-Kj for pgsql-hackers@arkaria.postgresql.org; Sat, 01 Oct 2022 12:07:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oebHT-0002HJ-I7 for pgsql-hackers@arkaria.postgresql.org; Sat, 01 Oct 2022 12:07:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oebHS-0002H9-GS for pgsql-hackers@lists.postgresql.org; Sat, 01 Oct 2022 12:07:43 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oebHO-000287-Ak for pgsql-hackers@postgresql.org; Sat, 01 Oct 2022 12:07:42 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C995C5C00B2; Sat, 1 Oct 2022 08:07:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 01 Oct 2022 08:07:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664626054; x= 1664712454; bh=padB/7HYZj/rtM/5WfFyboxXqge6Z8k/ESbcUp+iwpY=; b=r SBdmkXixXsMxLQc0eZCDoxWhq5dV44j50LKPTOUq/ih80k+E4yh/E/aXVoaa3BPD 2lDDUG/tOPE1cuQ+HMkyIlafm3O2IVen0YZ8gUhxcBWF9+LQeBR+UxfVuXGt6Z2F vwCgi8P9nrns0jO1jG+PV2jqLuwYFjbGXjyR8A31gchKrKAkMxht+sVXeTua09jj BQ1p6UX/9zsKxotIdXnJB2sGMCM/C5nEXgOFoTjJuDVtyfzoqNZ3/vMjo36SneXg 8m3PcJe3h5l9qSNmu9oou7/Ay0qojmOSMczDj2BDyPVM91gR6OLJHvrSzcV/8udt 4NU9w3801GWnBQPpP0b1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehgedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpefhjeduueelfeehuedt udefteejveegieeiueejueehfeektddtueeiieeitefhveenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 1 Oct 2022 08:07:30 -0400 (EDT) Message-ID: <73f18f58-5eaa-b09b-407d-a862a48635b1@enterprisedb.com> Date: Sat, 1 Oct 2022 14:07:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: ICU for global collation Content-Language: en-US To: Marina Polyakova Cc: Kyotaro Horiguchi , pgsql-hackers@postgresql.org, pryzby@telsasoft.com, rjuju123@gmail.com, daniel@manitou-mail.org, AndrewBille@gmail.com, michael@paquier.xyz References: <1f86f120-7b02-68f6-a434-132d054afe33@enterprisedb.com> <38d2aac40a991b20adf032e509c6eff5@postgrespro.ru> <6dd6db0984d86a51b7255ba79f111971@postgrespro.ru> <20220915.155210.529619933474389138.horikyota.ntt@gmail.com> <65ef1a8a-1fc3-3dc3-c7aa-6b9f649014b2@enterprisedb.com> <9ba4cd1ea6ed6b7b15c0ff15e6f540cd@postgrespro.ru> <218b963e-dd66-626a-abd8-962afb587876@enterprisedb.com> <36737f855bf3c44e701097cafd0ee2c9@postgrespro.ru> From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 22.09.22 20:06, Marina Polyakova wrote: > On 2022-09-21 17:53, Peter Eisentraut wrote: >> Committed with that test, thanks.  I think that covers all the ICU >> issues you reported for PG15 for now? > > I thought about the order of the ICU checks - if it is ok to check that > the selected encoding is supported by ICU after printing all the locale > & encoding information, why not to move almost all the ICU checks here?.. It's possible that we can do better, but I'm not going to add things like that to PG 15 at this point unless it fixes a faulty behavior.