Message-ID: <7422edbb-bf81-4f4f-b260-ce4d39a31007@gmail.com>
Date: Fri, 18 Aug 2023 10:57:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: WIP: new system catalog pg_wait_event
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>,
 Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, tgl@sss.pgh.pa.us,
 pgsql-hackers@lists.postgresql.org
References: <c915434a-3d3a-4135-8f3a-fca0cf22c6ae@gmail.com>
 <ZNNGq7DTv9ur5113@paquier.xyz>
 <b71d1977-1a8b-4129-8c03-533031dbd004@gmail.com>
 <ZNmvegQirGI9ifVw@paquier.xyz>
 <2f84b397-d020-493c-924c-610b9dd18f8d@gmail.com>
 <ZNxrMdmgrlovw1qD@paquier.xyz>
 <f2204399-cfdb-40e7-9479-9373ec6ba0ab@gmail.com>
 <735fbd560ae914c96faaa23cc8d9a118@oss.nttdata.com>
 <d28ad85d-1deb-4648-92a0-f38273fc91ca@gmail.com>
 <393fe340ab6980f399402a7dfbe13c4c@oss.nttdata.com>
 <ZN6hQDvWkLVaps9o@paquier.xyz>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZN6hQDvWkLVaps9o@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/7422edbb-bf81-4f4f-b260-ce4d39a31007%40gmail.com>
Precedence: bulk

Hi,

On 8/18/23 12:37 AM, Michael Paquier wrote:
> On Thu, Aug 17, 2023 at 04:37:22PM +0900, Masahiro Ikeda wrote:
>> On 2023-08-17 14:53, Drouvot, Bertrand wrote:
>> BTW, is it better to start with "Waiting" like any other lines?
>> For example, "Waiting for custom event \"worker_spi_main\" defined by an
>> extension".
> 
> Using "Waiting for custom event" is a good term here. 

Yeah, done in v8 just shared up-thread.

> I am wondering
> if this should be s/extension/module/, as an event could be set by a
> loaded library, which may not be set with CREATE EXTENSION.
> 

I think that removing "extension" sounds weird given the fact that the
wait event type is "Extension" (that could lead to confusion).

I did use "defined by an extension module" in v8 (also that's aligned with
the wording used in wait_event.h).

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com