From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Stephen Frost <sfrost@snowman.net>,
        Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        Robert Haas <robertmhaas@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
In-reply-to: <20220930214728.GA177925@nathanxps13>
References: <20220920180533.GA205278@nathanxps13>
 <20220920233117.GA378596@nathanxps13> <20220920235010.GB378596@nathanxps13>
 <Yyppg/c4SB7s1IAv@paquier.xyz> <20220921043126.GA382738@nathanxps13>
 <20220928185034.GA1397229@nathanxps13>
 <CAOuzzgpQtdqj2BfwheD9+fjUnVSo1cmdrQmwcr-qbvKjC5cfyg@mail.gmail.com>
 <20220928201222.GA1400058@nathanxps13> <20220930192350.GA171832@nathanxps13>
 <678838.1664568924@sss.pgh.pa.us> <20220930214728.GA177925@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Fri, 30 Sep 2022 14:47:28 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <742522.1664575253.1@sss.pgh.pa.us>
Date: Fri, 30 Sep 2022 18:00:53 -0400
Message-ID: <742523.1664575253@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/742523.1664575253%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> The main one I see is AclItem, which increases from 12 bytes to 16 bytes.

... and now requires double alignment ... did you fix its typalign?

We could conceivably dodge the alignment increase by splitting the 64-bit
field into two 32-bit fields, one for base privileges and one for grant
options.  That'd be rather invasive, so unless it leads to pleasant
improvements in readability (which it might, perhaps) I wouldn't advocate
for it.

			regards, tom lane