Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wAkJt-000HdA-1G for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Apr 2026 08:00:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wAkJr-004JK9-1L for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Apr 2026 08:00:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wAkJr-004JK1-0R for pgsql-hackers@lists.postgresql.org; Thu, 09 Apr 2026 08:00:56 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wAkJp-000000008xz-2vbP for pgsql-hackers@lists.postgresql.org; Thu, 09 Apr 2026 08:00:55 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-c76b6abdb73so445315a12.1 for ; Thu, 09 Apr 2026 01:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775721651; x=1776326451; darn=lists.postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VlsNb2hRGkvehXR+zVj2IBe2hTXYC+NHdjzKz8uOtCE=; b=r7GdAQUo08oyn5d2J1u1QWeXtpPpLCySB+KHOTDeRqLL15eGQa9plJPCkYrgMF+z5H tQH3/Lu/BjGEF0sneBi7WMlHeGpD+zhyKZYaTHas/voY3msYGYwTWlnVNzPu+7qSj1FW 7mK/bzAb3xzR+KCFvnKCvuU/GXwhHatgo1CUpUtjFQIG8prLQKxEEYLnvMEV8fGGMKAG 3OGngJoF1BJ5TH1l9E+o5b1uu7c7f9qphpWF4ZYzrBfO64Dw2tO6pC6YmrC1T/387DLR 8aX0cxqPsFWpdw510BzmspcYEQgDePTXZAkK7Rtvegzgh2F9SD7b0LaN0CvlorXahFIL +KyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775721651; x=1776326451; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VlsNb2hRGkvehXR+zVj2IBe2hTXYC+NHdjzKz8uOtCE=; b=MnJJOUe7Rnb+LM/RUWGICqUmJDYAfaIzqwSWg06nuLYiuyddRiub7JslD9OaLOWRpR eBUs6s0Ht/bPPGvc6eTQVfQHSSyUFUEhd03sPZ9S2cZ52KfBytJaHDH8pN957ou9Qr+H WC56PwQsI6sJ2Oqlc9O4GClZLsp6xtKnPV22IVtex1NhKzwO4YbwgbUs32ZlgmoJLz+L JQMi3dVrAweFAKaRbxNjqrtW+6UFaJD22UBXdD85Z2Kx/pClI0WiQl07Ils+IdMfEEtX hX6ZOOK5smdvsYSv3sRMW5nBesWf5Bv2s6cDa1zEdapqT31QE6HFntUcgJOXEWPh0KgD ywwA== X-Gm-Message-State: AOJu0YySDM7f2bFMZzOqzJiNU9JBNw7hA1k3Rx47pPn3rb1JhQO8wTgk e8UNXsTaA/9vbLiRSloMO+f5wQ/ABJBif5d0j4qwHqeylKKTHy94z1eO X-Gm-Gg: AeBDieuX9ZHjoLn6KMyEqEW1Z+Hpg7/vz4GIrZzuGcmcT3oq/MBXVNNjNGa6J/JBV4b dy6l48VNSfmNL05jEHlndKFC5mRzMvGzsCBt+TYsIsprrNiRQ8MY/+QwJuPqc6socOoDbBYDQry RiKy2lWbA6rKyKxKblvlKfIV+ZWIga/tWFViSRKEBrglfhf6fqC4RY+5EQoXQGvIq1FaaX4w50A LPWQmCU77BcvXFtpG9Llg4RN76FEiSAXEjzuXyDZps9V5UwZjSa83mUsgFl9BRkCZuuTJDSVJ5n wdxyEXimhDmQjkexf7/2tkOZ8jxcLrW2ON3S5d4H1lwnX+fveZMqEaaQ26nxdzmETbqHHNNgFKE a1wZ3sY9aHaMj1RjKpyauBcti91wd7NCpNsfDOuvWnLyKvvrwlVLQLYhPdFcTeV826LrX+fic7O 8lhxv/13L/sXPMQVDM2yt4UTzOVetZHTg= X-Received: by 2002:a05:6a21:339f:b0:39b:8545:f0e with SMTP id adf61e73a8af0-39fc80d1b9emr3344935637.8.1775721650210; Thu, 09 Apr 2026 01:00:50 -0700 (PDT) Received: from smtpclient.apple ([45.32.121.103]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76c6491157sm18944672a12.9.2026.04.09.01.00.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Apr 2026 01:00:49 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: Add missing period to DETAIL messages From: Chao Li In-Reply-To: Date: Thu, 9 Apr 2026 16:00:10 +0800 Cc: PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <74359511-9F84-481E-B133-D2F68775D1CE@gmail.com> References: To: Peter Smith X-Mailer: Apple Mail (2.3864.400.21) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Apr 9, 2026, at 12:27, Peter Smith wrote: >=20 > Hi, >=20 > According to the error message style guide [1] "Detail and hint > messages: Use complete sentences, and end each with a period." >=20 > I found some DETAIL messages not following that period rule. >=20 > PSA a patch that fixes the missing period. In passing, I also fixed > some capitalization. >=20 > =3D=3D=3D=3D=3D=3D > [1] = https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-G= UIDE-GRAMMAR-PUNCTUATION >=20 > Kind Regards, > Peter Smith. > Fujitsu Australia > ``` - errdetail("password must be at = least \"passwordcheck.min_password_length\" (%d) bytes long", + errdetail("password must be at = least \"passwordcheck.min_password_length\" (%d) bytes long.=E2=80=9D, ``` First =E2=80=9Cp=E2=80=9D should be capital. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/