Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXVUF-0000V5-Ji for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Mar 2022 21:59:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXVUE-0004Yu-9B for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Mar 2022 21:59:18 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXVUD-0004WE-Ke for pgsql-hackers@lists.postgresql.org; Thu, 24 Mar 2022 21:59:18 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nXVUB-0001Nl-1R for pgsql-hackers@lists.postgresql.org; Thu, 24 Mar 2022 21:59:16 +0000 Received: by mail-ej1-x632.google.com with SMTP id qx21so11814055ejb.13 for ; Thu, 24 Mar 2022 14:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=GIAvuXC7AsagQLhXHs+VLdFcUNz9Daz5IqN8jEdX6oE=; b=X7JPxolViqyFIbX7PTiqa9v+b0Fy77PhW0DMKfc7k9ADWU+H+RneMZOHQ1mPCU3mLv Vax4szvwpGK405uzakW4QMRgCaQSRhsqJAoMC8JQ0Tood1AZqTAaVl6aYp3AOtGm9Tpo ROhImCEA85AUWwIDWB7eDrnqixU32XfsEtdo1Gu1rSKWBcrhm98w39M1FwBe/1f1RP3F Bobuh85kSVQKWNByDNt6OigiUFnrLthkiU/6vjGq1GDRdjAOGdyTVWAf3K0621jYamFT 5Nhah8Bwo6OF4aepVyjcOKo0yeaobIZzExsCi0JpUG8xWu1wJz/3i+foeBvLos21Zmqt UOPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=GIAvuXC7AsagQLhXHs+VLdFcUNz9Daz5IqN8jEdX6oE=; b=Jdd81apAWy2SNPJxc1LSfXQFOiGLb6dGYVnfsMBAu+IX+p/3EQfLrkHB7/Y0U5NaKB TfMIZBJmh1HSssFqXiRtK2qbk4zug91fpjnVbq3zmF/mbtpD5Wu7hYROjZCqy3DWynpz aC9sFtRDwdwD05uM9ZuDaXncoDs45IeMnh3QHdlC4i7gwqsK63eDN2DdClpO6o5h/epW QU95nEAzhV4Nw3Uz5ly0UenTLTQ9cGPF04frjiTBfOihECA4dF6Wf6b+2WqXHa/TkQWv k6MpisV4gcTsnMR+UOE5xNC2Bela5juB8/3RsS3TuttyPYoLhZbo6zcsLBdoTwSiJdFa hRqQ== X-Gm-Message-State: AOAM533JBbXndbSr0MvwOfn96i/rPpwHCVZgWqEm+z+oMbtlQ9LLVvFu 9T7FjsfvwX83bHPcTOddgl0zQjQD6b8+g+IVVqufaKymlIL01WSiZ6i/OAtewzoRhMRxd4HG8gP T4DWMeui2939qnwGpAY6fuJ47yGgO34FnkK17OkUxUm6P0cqtLWUGt9p52x5DOOghzl5SXxtiA9 fdVgKX+rMMgQXDMN3PL4NHhngEplwwQuDx0yaMPLXJWgJz0kr2EL97 X-Google-Smtp-Source: ABdhPJw4/eBFRNN9C21xarZpXGA3/R0YYRCfXCekGDh6eVJI89kgoyO1758L7C7N1hF+F4kJ4HVkUQ== X-Received: by 2002:a17:907:6d0d:b0:6db:f0f8:654d with SMTP id sa13-20020a1709076d0d00b006dbf0f8654dmr8189556ejc.304.1648159153683; Thu, 24 Mar 2022 14:59:13 -0700 (PDT) Received: from [10.137.0.17] (ip-86-49-251-241.net.upcbroadband.cz. [86.49.251.241]) by smtp.gmail.com with ESMTPSA id z1-20020a05640235c100b004192c7266f5sm1917395edc.16.2022.03.24.14.59.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Mar 2022 14:59:12 -0700 (PDT) Message-ID: <74729cc5-960b-9295-912a-a7c37356a0c4@enterprisedb.com> Date: Thu, 24 Mar 2022 22:59:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: logical decoding and replication of sequences Content-Language: en-US From: Tomas Vondra To: Petr Jelinek , Amit Kapila Cc: Peter Eisentraut , PostgreSQL Hackers References: <41ada110-bc7c-32a3-08bd-fb5023dd74ba@enterprisedb.com> <2eed0f76-3a1a-8b8b-ac1b-e0f9a0d98287@enterprisedb.com> <9defb937-20a9-1d9f-6972-f1c4b4da4f73@enterprisedb.com> <8e766e0f-ed3e-fd68-4b0f-10dd2db60c88@enterprisedb.com> <6b21233e-c880-e4ad-5df2-7832f769296c@enterprisedb.com> <9da788c7-01eb-f11d-aa08-c5f61fe9f33a@enterprisedb.com> <456A528F-8F19-41C7-9857-927024D32396@enterprisedb.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, Pushed, after going through the patch once more, addressed the remaining FIXMEs, corrected a couple places in the docs and comments, etc. Minor tweaks, nothing important. I've been thinking about the grammar a bit more after pushing, and I realized that maybe it'd be better to handle the FOR ALL TABLES / SEQUENCES clause as PublicationObjSpec, not as a separate/special case. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company