From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: Jacob Champion <pchampion@vmware.com>,
 "daniel@yesql.se" <daniel@yesql.se>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        "michael@paquier.xyz" <michael@paquier.xyz>
Subject: Re: Preventing abort() and exit() calls in libpq
In-reply-to: <a6c5b570-a7b7-bd0b-59e7-33af54f51dbe@enterprisedb.com>
References: <3128896.1624742969@sss.pgh.pa.us>
 <18eda75d-af6d-3fc0-03b6-607eff9f392a@enterprisedb.com>
 <622907.1625084114@sss.pgh.pa.us> <630837.1625092151@sss.pgh.pa.us>
 <67ddcb26f82acaffb26c59b7d8e4cd75399b2cd3.camel@vmware.com>
 <9d35a4ac-2c75-cb44-95ab-61d69deb072e@enterprisedb.com>
 <745046.1625163264@sss.pgh.pa.us>
 <a6c5b570-a7b7-bd0b-59e7-33af54f51dbe@enterprisedb.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@enterprisedb.com>
	message dated "Thu, 01 Jul 2021 21:03:58 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <748143.1625166605.1@sss.pgh.pa.us>
Date: Thu, 01 Jul 2021 15:10:05 -0400
Message-ID: <748144.1625166605@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/748144.1625166605%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 01.07.21 20:14, Tom Lane wrote:
>> The problem then is, what happens when the extra action fails?
>> Without .DELETE_ON_ERROR, the shlib is still there and the next
>> make run will think everything's good.

> Right.  .DELETE_ON_ERROR is already set in Makefile.global, so it's not 
> necessary to set it again.

Right.  Since we use that, we don't actually have that problem.
What we'd have instead is that debugging an unexpected failure
of the "extra action" would be painful, because there would be
no way short of modifying the Makefiles to create its input data.
So I think the other solution with a separate rule is better.

			regards, tom lane