Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hWi2O-0008Nw-MZ
	for pgsql-hackers@arkaria.postgresql.org; Fri, 31 May 2019 13:57:40 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hWi2N-0006Rk-G5
	for pgsql-hackers@arkaria.postgresql.org; Fri, 31 May 2019 13:57:39 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hWi2N-0006Rc-7D
	for pgsql-hackers@lists.postgresql.org; Fri, 31 May 2019 13:57:39 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hWi2L-0006zm-2A
	for pgsql-hackers@lists.postgresql.org; Fri, 31 May 2019 13:57:38 +0000
Received: from pro.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x4VDvVvo008552;
	Fri, 31 May 2019 09:57:31 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: tableam.h fails cpluspluscheck
In-reply-to: <20190530204705.3xnmpuxd23tovbyb@alap3.anarazel.de>
References: <53941.1559239260@sss.pgh.pa.us>
 <20190530204705.3xnmpuxd23tovbyb@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 30 May 2019 13:47:05 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <74836.1559311051.1@sss.pgh.pa.us>
Date: Fri, 31 May 2019 09:57:31 -0400
Message-ID: <74837.1559311051@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2019-05-30 14:01:00 -0400, Tom Lane wrote:
>> Kinda looks like you can't get away with using "struct" on a forward
>> declaration of something that is not actually a struct type.

> Ugh. Odd that only C++ compilers complain. I just removed the typedef,
> it's not needed anymore (it used to be neccessary before moving
> IndexBuildCallback's definition to tableam.h - but was wrong then too,
> just cpluspluscheck didn't notice).

Cool, thanks.

			regards, tom lane