Message-ID: <748a7ec0-9126-4f27-a2a7-e3e449d6fdd7@uni-muenster.de>
Date: Thu, 28 Nov 2024 15:22:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Truncate logs by max_log_size
To: Kirill Reshke <reshkekirill@gmail.com>,
 Kirill Gavrilov <diphantxm@gmail.com>
Cc: "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
 Euler Taveira <euler@eulerto.com>, pgsql-hackers@lists.postgresql.org
References: <CA+E0NR4S+NC6+QHyY_vUuQZMzLhKqczMx-jJVqtjAxF6+=JwAA@mail.gmail.com>
 <94d53a41-d1f5-4fd1-8d1e-ff36ac569848@app.fastmail.com>
 <4DA5A159-39FD-47DB-95E5-A4F65BC5782A@yandex-team.ru>
 <53e96b5a-cc77-4afa-8103-79c69afef1a6@uni-muenster.de>
 <CA+E0NR4=J-pgqEAV2weymygGmk1ePym45m2AcGyi2hpa9xRvBg@mail.gmail.com>
 <CALdSSPiq+x9pRVYvYtddTQsL8=ZMvob+vSv5mHEXbe0aoPWGig@mail.gmail.com>
Content-Language: en-US
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: <CALdSSPiq+x9pRVYvYtddTQsL8=ZMvob+vSv5mHEXbe0aoPWGig@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/748a7ec0-9126-4f27-a2a7-e3e449d6fdd7%40uni-muenster.de>
Precedence: bulk


On 25.11.24 17:52, Kirill Reshke wrote:
> Hello! Please deliver the most recent patch version and fix the issues
> Jim identified [0] as the current commitfest draws to a close.
> Do not forget to include both parts of this patch (This was actually
> developed off-list, and we are now using this on our cloud PostgreSQL
> distribution on versions 12–17).
>
> [0] https://www.postgresql.org/message-id/35096a36-04d4-480b-a7cd-a2d8151fb737%40uni-muenster.de

In addition to these points, this feature seems to fail with queries
containing special characters (more than one byte):

With this "max_log_size"..

postgres=# SHOW max_log_size;
 max_log_size
--------------
 20
(1 row)

... and this query ..

postgres=# SELECT "ÄÜÖ" FROM t;
ERROR:  relation "t" does not exist
LINE 1: SELECT "ÄÜÖ" FROM t;

.. this is the [truncated] log entry we get ..

2024-11-28 14:58:57.912 CET [2258876] ERROR:  relation "t" does not
exist at character 19
2024-11-28 14:58:57.912 CET [2258876] STATEMENT:  SELECT "ÄÜÖ" FROM

... although the query originally had exactly 20 characters:

postgres=# SELECT length('SELECT "ÄÜÖ" FROM t;');
 length
--------
     20
(1 row)


postgres=# SELECT length('ÄÜÖ'::bytea), length('AUO'::bytea);
 length | length
--------+--------
      6 |      3
(1 row)

If it is supposed to be like this, it should be clearly stated so in the
docs.

-- 
Jim