From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: split TOAST support out of postgres.h
In-reply-to: <fa03b216-2e81-4fe9-c4fa-bbf3c2058d0b@enterprisedb.com>
References: <ddcce239-0f29-6e62-4b47-1f8ca742addf@enterprisedb.com>
 <320834.1672240076@sss.pgh.pa.us>
 <fa03b216-2e81-4fe9-c4fa-bbf3c2058d0b@enterprisedb.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@enterprisedb.com>
	message dated "Fri, 30 Dec 2022 12:53:08 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <749874.1672419036.1@sss.pgh.pa.us>
Date: Fri, 30 Dec 2022 11:50:36 -0500
Message-ID: <749875.1672419036@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/749875.1672419036%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 28.12.22 16:07, Tom Lane wrote:
>> I dunno, #3 seems kind of unprincipled.  Also, since fmgr.h is included
>> so widely, I doubt it is buying very much in terms of reducing header
>> footprint.  How bad is it to do #2?

> See this incremental patch set.

Wow, 41 files requiring varatt.h is a lot fewer than I would have guessed.
I think that bears out my feeling that fmgr.h wasn't a great location:
I count 117 #includes of that, many of which are in .h files themselves
so that many more .c files would be required to read them.

(You did check that this passes cpluspluscheck/headerscheck, right?)

> It seems like maybe there is some intermediate abstraction that a lot of 
> these places should be using that we haven't thought of yet.

Hmm.  Perhaps, but I think I'm content with this version of the patch.

			regards, tom lane