From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Stephen Frost <sfrost@snowman.net>,
        Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        Robert Haas <robertmhaas@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
In-reply-to: <20220930223257.GA190214@nathanxps13>
References: <20220920235010.GB378596@nathanxps13>
 <Yyppg/c4SB7s1IAv@paquier.xyz> <20220921043126.GA382738@nathanxps13>
 <20220928185034.GA1397229@nathanxps13>
 <CAOuzzgpQtdqj2BfwheD9+fjUnVSo1cmdrQmwcr-qbvKjC5cfyg@mail.gmail.com>
 <20220928201222.GA1400058@nathanxps13> <20220930192350.GA171832@nathanxps13>
 <678838.1664568924@sss.pgh.pa.us> <20220930214728.GA177925@nathanxps13>
 <742523.1664575253@sss.pgh.pa.us> <20220930223257.GA190214@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Fri, 30 Sep 2022 15:32:57 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <749975.1664579138.1@sss.pgh.pa.us>
Date: Fri, 30 Sep 2022 19:05:38 -0400
Message-ID: <749976.1664579138@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/749976.1664579138%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Fri, Sep 30, 2022 at 06:00:53PM -0400, Tom Lane wrote:
>> ... and now requires double alignment ... did you fix its typalign?

> Nope, I missed that, thanks for pointing it out.  Should we move ai_privs
> to the beginning of the struct, too?

Don't see any point, there won't be any padding.  If we ever change the
sizeof(Oid), or add more fields, we can consider what to do then.

			regards, tom lane