Subject: Re: backend type in log_line_prefix?
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <20200310180731.GA15183@alvherre.pgsql>
 <bd9a336e-1c99-e3dd-8bec-07f2c41723ba@2ndquadrant.com>
 <5d8f84b8-fc8d-0cb3-e887-32f7c7102c1b@2ndquadrant.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <750adb5e-03c2-7e97-45a3-14874ff64d1b@oss.nttdata.com>
Date: Mon, 16 Mar 2020 12:04:10 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <5d8f84b8-fc8d-0cb3-e887-32f7c7102c1b@2ndquadrant.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2020/03/15 19:32, Peter Eisentraut wrote:
> On 2020-03-13 22:24, Peter Eisentraut wrote:
>> On 2020-03-10 19:07, Alvaro Herrera wrote:
>>> I like these patches; the first two are nice cleanup.
>>>
>>> My only gripe is that pgstat_get_backend_desc() is not really a pgstat
>>> function; I think it should have a different name with a prototype in
>>> miscadmin.h (next to the enum's new location, which I would put
>>> someplace near the "pmod.h" comment rather than where you put it;
>>> perhaps just above the AuxProcType definition), and implementation
>>> probably in miscinit.c.
>>
>> I have committed the refactoring patches with adjustments along these
>> lines.  The patch with the log_line_prefix and csvlog enhancements is
>> still under discussion.
> 
> I have committed that last one also, after some corrections.

Thanks for adding this nice feature!

I have one comment; You seem to need to update file-fdw.sgml so that
pglog table in the doc should include backend_type column.

Regards,


-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters