Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnzR2-0005uk-76 for pgsql-hackers@arkaria.postgresql.org; Sat, 02 Sep 2017 03:49:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dnzR1-0007Np-Q4 for pgsql-hackers@arkaria.postgresql.org; Sat, 02 Sep 2017 03:49:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dnzR0-0007Mp-U9 for pgsql-hackers@postgresql.org; Sat, 02 Sep 2017 03:49:26 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dnzQx-0005OG-Fh for pgsql-hackers@postgresql.org; Sat, 02 Sep 2017 03:49:26 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 03E1320BE6; Fri, 1 Sep 2017 23:49:22 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Fri, 01 Sep 2017 23:49:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=Go6qeh9xuqInmJklotJ146O27O1WKqS7KqeeT0fslh0=; b=XnFuJlgV zdXz0iCjwayH/hTWff5sg4Myp2AjkZpnTgWOnHSL5vhhD2nuwU3yuMGIOmyjzg19 SVkZVe2g42wPLt+3wulpuP0p4CDkVS8zjtd1W436kRcQ5t2EO8OHXQiNU6I6MWFx 2tmOPO/jCxLHO336qdIg2bMYi55Vnj42X9VCttHILuuXnBv6lv/Jd/H5VXTjb2VA m35m5N7rqo9F8bEA8Mg53zoY+0IHjMn6pxkRWPUMz0KScWWER+olp36uUEx9Eus2 hrF894qq79UTVCGKFIrnFzZNjivZwAxXvSoaNFms12oJwUjXCBzTOCAUjY/Sj2mU A/FcF6YltSHZ+A== X-ME-Sender: X-Sasl-enc: VxxE2xOvcUoynlxVFxJdEXvkx2nkevDDTd9c48hgwxd/ 1504324161 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id B86887E271; Fri, 1 Sep 2017 23:49:21 -0400 (EDT) Subject: Re: Restricting maximum keep segments by repslots To: Kyotaro HORIGUCHI References: <20170302.095414.264042561.horiguchi.kyotaro@lab.ntt.co.jp> <20170306.182006.172683338.horiguchi.kyotaro@lab.ntt.co.jp> <20170828.183614.200480339.horiguchi.kyotaro@lab.ntt.co.jp> Cc: pgsql-hackers@postgresql.org From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <751e09c4-93e0-de57-edd2-e64c4950f5e3@2ndquadrant.com> Date: Fri, 1 Sep 2017 23:49:21 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170828.183614.200480339.horiguchi.kyotaro@lab.ntt.co.jp> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org I'm still concerned about how the critical situation is handled. Your patch just prints a warning to the log and then goes on -- doing what? The warning rolls off the log, and then you have no idea what happened, or how to recover. I would like a flag in pg_replication_slots, and possibly also a numerical column that indicates how far away from the critical point each slot is. That would be great for a monitoring system. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers