From: Antonin Houska <ah@cybertec.at>
To: alvherre@kurilemu.de
cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
    Robert Treat <rob@xzilla.net>,
    Pg Hackers <pgsql-hackers@lists.postgresql.org>,
    Fujii Masao <masao.fujii@gmail.com>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: <202510070909.biaseppvydvg@alvherre.pgsql>
References: <202510070909.biaseppvydvg@alvherre.pgsql>
Comments: In-reply-to =?us-ascii?Q?=3D=3Futf-8=3FQ=3F=3DC3=3D81lvaro=3F=3D?=
 Herrera <alvherre@kurilemu.de>
   message dated "Tue, 07 Oct 2025 16:05:33 +0200."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Thu, 09 Oct 2025 08:38:15 +0200
Message-ID: <7535.1759991895@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/7535.1759991895%40localhost>
Precedence: bulk

=C3=81lvaro Herrera <alvherre@kurilemu.de> wrote:

> On 2025-Sep-26, Mihail Nikalayeu wrote:
>=20
> > Should we rename it to repack_context to be aligned with the calling si=
de?
>=20
> Sure, done.
>=20
> > > cmd =3D=3D REPACK_COMMAND_CLUSTER ? "CLUSTER" : "REPACK",
> >=20
> > May be changed to RepackCommandAsString
>=20
> Oh, of course.
>=20
> > Documentation of pg_repackdb contains a lot of "analyze" and even
> > "--analyze" parameter - but I can't see anything related in the code.
>=20
> Hmm, yeah, that was missing.  I added it.  In doing so I noticed that
> because vacuumdb allows a column list to be given, then we should do
> likewise here, both in pg_repackdb and in the REPACK command, so I added
> support for that.

+	/*
+	 * Make sure ANALYZE is specified if a column list is present.
+	 */
+	if ((params->options & CLUOPT_ANALYZE) =3D=3D 0 && stmt->relation->va_col=
s !=3D NIL)
+		ereport(ERROR,
+				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+				 errmsg("ANALYZE option must be specified when a column list is provid=
ed")));

Shouldn't the user documentation mention this restriction?

--=20
Antonin Houska
Web: https://www.cybertec-postgresql.com