public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andrew Dunstan <[email protected]>
To: Thomas Munro <[email protected]>
To: Jakub Wartak <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Dimitrios Apostolou <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: [email protected]
Cc: Andres Freund <[email protected]>
Cc: Melanie Plageman <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: David Rowley <[email protected]>
Subject: Re: [PING] fallocate() causes btrfs to never compress postgresql files
Date: Fri, 6 Feb 2026 09:12:20 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+hUKGJ5AfAq-spM=b+KD0LNNXY-gAgaDDox9YFQZM+t8+je=g@mail.gmail.com>
References: <[email protected]>
	<CABUevExxDKNsnwJ_hmt7Y4k_0zjy6wMoqsTBAEUZix4EkKQvnA@mail.gmail.com>
	<CA+hUKGKGgDOdS=n77p1=VUf5=XV2=L7VSiZW99Re7kUTRGMgxQ@mail.gmail.com>
	<CABUevEx=CQcphH33TRcMeUkt-TZ=m+i1JhLHCdoB_FYE5ift2w@mail.gmail.com>
	<CA+hUKGL74G_CR50N+gr8N1E9emuFJMHAsEKr6oGmHZZDZjRJHg@mail.gmail.com>
	<[email protected]>
	<CA+hUKGJQ=V4S-5Z=D6cDfsOz_7vGAAusj2b3fO36GuezcADamQ@mail.gmail.com>
	<CAKZiRmzF6SRR+AxPZsXzs1kaHrxjLO2sbLT4Q61EMA5PGQB3Vg@mail.gmail.com>
	<[email protected]>
	<CA+hUKGJbEp5fBfkS+J5OcrEzPTwugEtiusndiCx4gnN7HKfdpg@mail.gmail.com>
	<CAKZiRmzdvqtuZmrpUi-399gzko6xihDgCkJyTv--Sk4pgQ4x+g@mail.gmail.com>
	<CAKZiRmyDR5d7jdKdhL6TNKMtcY0fAaS-OQ3Bk3ZVejLZMrTCQw@mail.gmail.com>
	<CA+hUKG+cFFzRNqV=+XJOdtzkj0jDGfCjL6BLKtZ43css=_RFmw@mail.gmail.com>
	<CAKZiRmyrPZ+U5p39oaj3nfOtteoz4cA63pZTyE-2wVVOuXuqKQ@mail.gmail.com>
	<CA+hUKGJ5AfAq-spM=b+KD0LNNXY-gAgaDDox9YFQZM+t8+je=g@mail.gmail.com>


On 2026-02-06 Fr 3:29 AM, Thomas Munro wrote:
> On Fri, Feb 6, 2026 at 8:19 PM Jakub Wartak
> <[email protected]> wrote:
>> On Fri, Feb 6, 2026 at 6:12 AM Thomas Munro <[email protected]> wrote:
>>> On Mon, Jan 12, 2026 at 11:04 PM Jakub Wartak
>>> <[email protected]> wrote:
>>>>>> I'm proposing to back-patch 0001.  0002 and 0003 are proposals for master only.
>>>> Do you have any plans to commit this before February (before next
>>>> minor release) or perhaps do you need some further input or help in
>>>> this $thread? (I'm mainly after the XFS thingy, but we kill two birds
>>>> with 1 stone here).
>>> Pushed.
>> Thank You very much !
> BTW the rest of the patches will reemerge for master, but for the
> minimal one back-patched: crake complains about an ABI break due to
> GUC table changes.  Of course adding a GUC to the stable branches is
> unusual and we discussed the need for it in this case.  Is that
> expected?  In what way is it part of the ABI?  How would one determine
> in advance that the ABI checker will complain?
>
>

First, thanks for committing this.

How to tell it will detect a break is a good question. I guess a trivial 
answer would be to run the buildfarm client with the ABICompCheck module 
enabled, but that's probably a big ask if you're not set up for it. This 
one is relatively hard to catch because tthe ABI change is in a 
generated file, so the triggering source change isn't even in the 
include directory.

Not sure if we want to start using a suppressions file to exclude 
certain symbols from consideration. They are described here 
https://man7.org/linux/man-pages/man7/libabigail.7.html


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com







view thread (6+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PING] fallocate() causes btrfs to never compress postgresql files
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox