Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h47X9-0001VJ-ST for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Mar 2019 17:19:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h47X8-0003mQ-Me for pgsql-hackers@arkaria.postgresql.org; Wed, 13 Mar 2019 17:19:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h47X8-0003mJ-C5 for pgsql-hackers@lists.postgresql.org; Wed, 13 Mar 2019 17:19:14 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h47X1-0006C3-Jb for pgsql-hackers@postgresql.org; Wed, 13 Mar 2019 17:19:13 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x2DHJ000007555; Wed, 13 Mar 2019 13:19:00 -0400 From: Tom Lane To: Sergei Kornilov cc: Robert Haas , David Rowley , PostgreSQL mailing lists , Alvaro Herrera , Stephen Frost , Ildar Musin Subject: Re: using index or check in ALTER TABLE SET NOT NULL In-reply-to: <7254.1552496972@sss.pgh.pa.us> References: <880511520351578@web5j.yandex.ru> <20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql> <1715451520361128@web26o.yandex.ru> <1142.1520362313@sss.pgh.pa.us> <082cf493-a989-dcd6-7baf-a94a40d07ea0@postgrespro.ru> <2947361520607085@web26g.yandex.ru> <5376321520674521@web1j.yandex.ru> <979461523301587@web39j.yandex.ru> <247201523472946@web58j.yandex.ru> <3654591523776151@web39j.yandex.ru> <9345791551814869@myt2-cd7fa496c4f7.qloud-c.yandex.net> <7479161552216397@iva6-19b25c513db4.qloud-c.yandex.net> <694691552422467@myt1-06117f29c1ea.qloud-c.yandex.net> <21516.1552489217@sss.pgh.pa.us> <2123251552490241@myt6-fe24916a5562.qloud-c.yandex! ! .net> <2815991552495610@myt1-4903e6646a45.qloud-c.yandex.net> <7254.1552496972@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Wed, 13 Mar 2019 13:09:32 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7553.1552497539.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 13 Mar 2019 13:19:00 -0400 Message-ID: <7554.1552497540@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I wrote: > Sergei Kornilov writes: >>> Ugh, I guess so. Or how about changing the message itself to use >>> INFO, like we already do in QueuePartitionConstraintValidation? >> Fine for me. But year ago this was implemented in my patch and Tom vote= d against using INFO level for such purpose: https://www.postgresql.org/me= ssage-id/1142.1520362313%40sss.pgh.pa.us > What I thought then was that you didn't need the message at all, > at any debug level. I still think that. Oh, and yes, I think QueuePartitionConstraintValidation's usage is an unacceptable abuse of INFO level. I'm surprised we haven't gotten complaints about it yet. regards, tom lane