public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: jian he <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Tommy Pavlicek <[email protected]>
Cc: [email protected]
Cc: Tomas Vondra <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] ltree hash functions
Date: Thu, 21 Mar 2024 18:29:43 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxEjNrchox2FA1e2oCNTcgZeDDhCfyDhbC2+istv7FJiuQ@mail.gmail.com>
References: <CAEhP-W9ZEoHeaP_nKnPCVd_o1c3BAUvq1gWHrq8EbkNRiS9CvQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CAEhP-W_qmjy7ZwkhCyhbs-fCx_mPoeeK977wSN_fqsMAVJ7Qqg@mail.gmail.com>
<[email protected]>
<CAEhP-W-dqWKLNUQEGSb+06mo-5hP6MTCBeL4RkxosVh+8pQQfg@mail.gmail.com>
<CACJufxGd4_qSqU3-j9TFOS7JD0Jx+fSFNdVBnEeprP35ppFscQ@mail.gmail.com>
<CAEhP-W8_N3seEhQVDhTxV17qn3qZsN6-xhc=Qn=AwLn+WmKWPA@mail.gmail.com>
<CACJufxHJKxQ=foYiOzbtd2mSTn-CXyKd6za0eR73moToUA6uJg@mail.gmail.com>
<CAEhP-W_Fbxw4o8ccN22gcfktqV2yq7Bz6VfubKLJfRxWWW_aAw@mail.gmail.com>
<CALDaNm3=wWsZo7hWJGad7YUEX2j+Ka96g6W-AVwM=K3Bg3tg9A@mail.gmail.com>
<CACJufxEjNrchox2FA1e2oCNTcgZeDDhCfyDhbC2+istv7FJiuQ@mail.gmail.com>
jian he <[email protected]> writes:
> I also made the following changes:
> from
> uint64 levelHash = hash_any_extended((unsigned char *) al->name, al->len, seed);
> uint32 levelHash = hash_any((unsigned char *) al->name, al->len);
> to
> uint64 levelHash = DatumGetUInt64(hash_any_extended((unsigned char *)
> al->name, al->len, seed));
> uint32 levelHash = DatumGetUInt32(hash_any((unsigned char *) al->name,
> al->len));
Yeah, that'd fail on 32-bit machines.
Pushed v5 with some minor cosmetic tweaking.
regards, tom lane
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] ltree hash functions
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox