Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s83sH-009Mto-LH for pgsql-hackers@arkaria.postgresql.org; Fri, 17 May 2024 20:08:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s83sH-00HKUB-Mv for pgsql-hackers@arkaria.postgresql.org; Fri, 17 May 2024 20:08:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s83sH-00HKU3-Bb for pgsql-hackers@lists.postgresql.org; Fri, 17 May 2024 20:08:17 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1s83sD-000lV0-2e for pgsql-hackers@lists.postgresql.org; Fri, 17 May 2024 20:08:15 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1ee7963db64so20388795ad.1 for ; Fri, 17 May 2024 13:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1715976491; x=1716581291; darn=lists.postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ftKVKuWO5IucS/t2qXxUdTRXM6VlobAvsf8kZ/ltUiI=; b=Fkp4MURArwZZrVwMzEtCrg5Q0OVxsTwaKm1z75k0Q84h2go6Rp62fnCEtkph2EX0Sg jsz/4XH3amAlrG9Rz4rBHnRwNO0SxtVCpBF2VhOZzDiVwdo4h3j5Cy44totBikFSLSpw p7en6apgaTCNtNxTI+h4/dVh2D/84l3NjMD02mozd7PHOTyVqpwZhfja6tIxpf6X7td1 rSBlQy2qcNptJuHWA3lYl+wgSp2HJ26yGWzni9ohmnKmhTxsIVQC76Pbiujv5kO9r66X OymyNnPfKPuwDrMc4K0l73jClLX4n8yVDfH/j1RaAUnuX/o0oPAI1VxLnbDcT2AnKpZe QNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715976491; x=1716581291; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ftKVKuWO5IucS/t2qXxUdTRXM6VlobAvsf8kZ/ltUiI=; b=enWhe68NITse3/C4uxaOdS7/OCpHy+pxRk5aN6bZss436EWScekIBw82pXs4pC8tDj Znt7VnUv7dJEv/V1INgOiX+HEjYuSDCsvG10SRrBhTUWQQCd3l39lK52RE5YvOGOh4AX rbbJJFC4ni1rB6Swm95ajQbi9iIVgKUSUSVD0ViaFPOMK6ADuph0VYssyZPXmVzXXlw7 CVKKhR0xOOWecRMF1nAXezYiptLdk+ridOs7zsM5EINYaxOQGRUIPxyXMGuLLmHx9K+u s8iAQ8w11QFDlFjjPrf5kJ/8xlRj4DmhcEDJZO+dEZ/z3yxZYzgVOFqYij61lJxEo/rK v3ag== X-Forwarded-Encrypted: i=1; AJvYcCUzurZ15io666ad0gn3A2C1KCgQFzbcLcyFJlDInrYrGgPXlw5c8mhISDqUctXvX4mWYcETsTUEnufRZ5eBsRprAp8dRKLauSTuVSImbNp6FIef X-Gm-Message-State: AOJu0Yx3wZoQCU8Aifu8VLjKyI/juWmY5RtJkl+wF1JFgYlk1ylNeqWx y4V2w9hmgJvNHln9ZYjytbXOnYSuiKPweMbcwxjL8m1bwhhSS7jo2pFxkE0TsA== X-Google-Smtp-Source: AGHT+IHXwoL6kyrlRfLWlAzhV0EvXX60csPXfccGSprSjbRhp547hUV4SW0MThwl3uVq8nTMAuZ20A== X-Received: by 2002:a17:90a:d084:b0:2b1:a31e:9aba with SMTP id 98e67ed59e1d1-2b6ccc72fc4mr22170308a91.38.1715976491317; Fri, 17 May 2024 13:08:11 -0700 (PDT) Received: from smtpclient.apple (24-113-197-127.wavecable.com. [24.113.197.127]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2b62886cf36sm17773886a91.30.2024.05.17.13.08.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2024 13:08:10 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Subject: Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. From: Mark Dilger In-Reply-To: Date: Fri, 17 May 2024 13:08:10 -0700 Cc: Alexander Korotkov , Tom Lane , Noah Misch , Peter Eisentraut , Aleksander Alekseev , Postgres hackers , Maxim Orlov , Andres Freund , Greg Stark , Julien Rouhaud , David Steele , Peter Geoghegan , Maxim Orlov , lubennikovaav@gmail.com Content-Transfer-Encoding: quoted-printable Message-Id: <7565C305-F043-448C-A77C-D1CE91A72053@enterprisedb.com> References: <20220922151328.lakwdytvwnyyif3b@awork3.anarazel.de> <8c74cc5e-4b97-4cd7-9aaf-67886822a78c@eisentraut.org> <20240501022412.85@rfd.leadboat.com> <1375614.1715301775@sss.pgh.pa.us> <8635D8B1-45B7-4D67-86C7-D6ECB4F10B11@enterprisedb.com> <2EDAC2EB-E8C2-4B56-9094-288ABD45DA4E@enterprisedb.com> <28FCD9E5-795E-44F4-ADFA-DBCAC1945DA1@enterprisedb.com> To: Pavel Borisov X-Mailer: Apple Mail (2.3731.700.6.1.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On May 17, 2024, at 12:42 PM, Pavel Borisov = wrote: >=20 > At the first glance it's not clear to me:=20 > - why your test creates cross-page unique constraint violations? To see if they are detected. > - how do you know they are not detected? It appears that they are detected. At least, rerunning the test after = adjusting the expected output, I no longer see problems. =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company