From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Noah Misch <noah@leadboat.com>,
        Jacob Champion <jacob.champion@enterprisedb.com>,
        Denis Laxalde <denis.laxalde@dalibo.com>,
        vignesh C <vignesh21@gmail.com>, Thomas Munro <thomas.munro@gmail.com>,
        Greg Stark <stark@mit.edu>,
        "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
        Jelte Fennema <Jelte.Fennema@microsoft.com>,
        Daniel Gustafsson <daniel@yesql.se>,
        Peter Eisentraut <peter@eisentraut.org>,
        Andres Freund <andres@anarazel.de>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Robert Haas <robertmhaas@gmail.com>,
        pgsql-hackers@lists.postgresql.org,
        Etsuro Fujita <etsuro.fujita@gmail.com>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
In-reply-to: <202403281115.sy2xffc2ms2d@alvherre.pgsql>
References: <202403281115.sy2xffc2ms2d@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Thu, 28 Mar 2024 12:15:08 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <757341.1712254010.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 04 Apr 2024 14:06:50 -0400
Message-ID: <757342.1712254010@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/757342.1712254010%40sss.pgh.pa.us>
Precedence: bulk

[ from a week ago ]

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Hm, indri failed:
> ccache gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-afte=
r-statement -Werror=3Dvla -Werror=3Dunguarded-availability-new -Wendif-lab=
els -Wmissing-format-attribute -Wcast-function-type -Wformat-security -fno=
-strict-aliasing -fwrapv -Wno-unused-command-line-argument -Wno-compound-t=
oken-split-by-macro -g -O2 -fno-common -Werror  -fvisibility=3Dhidden -bun=
dle -o dblink.dylib  dblink.o -L../../src/port -L../../src/common -L../../=
src/interfaces/libpq -lpq -isysroot /Applications/Xcode.app/Contents/Devel=
oper/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.4.sdk  -L/opt/local=
/libexec/llvm-15/lib -L/opt/local/lib -L/opt/local/lib -L/opt/local/lib  -=
L/opt/local/lib -Wl,-dead_strip_dylibs  -Werror  -fvisibility=3Dhidden -bu=
ndle_loader ../../src/backend/postgres

> Undefined symbols for architecture arm64:
>   "_libintl_gettext", referenced from:
>       _libpqsrv_cancel in dblink.o
>       _libpqsrv_cancel in dblink.o
> ld: symbol(s) not found for architecture arm64
> clang: error: linker command failed with exit code 1 (use -v to see invo=
cation)
> make[1]: *** [dblink.dylib] Error 1
> make: *** [all-dblink-recurse] Error 2

Having just fixed the same issue for test_json_parser, I now realize
what's going on there: dblink's link command doesn't actually mention
any of the external libraries that we might need, such as libintl.
You can get away with that on some platforms, but not macOS.
It would probably be possible to fix that if anyone cared to.
I'm not sufficiently excited about it to do so right now --- as
you say, we don't support translation in contrib anyway.

			regards, tom lane