Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eFRel-0006Az-UP
	for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Nov 2017 21:25:08 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eFRel-0001bI-Eg
	for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Nov 2017 21:25:07 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eFRel-0001Ym-6C
	for pgsql-hackers@lists.postgresql.org; Thu, 16 Nov 2017 21:25:07 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eFRei-0008CH-9x
	for pgsql-hackers@lists.postgresql.org; Thu, 16 Nov 2017 21:25:06 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id vAGLP3JX007579;
	Thu, 16 Nov 2017 16:25:03 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Anthony Bykov <a.bykov@postgrespro.ru>
cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Rewriting PL/Python's typeio code
In-reply-to: <28605.1510759393@sss.pgh.pa.us>
References: <24449.1509393613@sss.pgh.pa.us> <24449.1509393613@sss.pgh.pa.us>
 <20171115110823.1377.63193.pgcf@coridan.postgresql.org>
 <28605.1510759393@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Wed, 15 Nov 2017 10:23:13 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7577.1510867503.1@sss.pgh.pa.us>
Date: Thu, 16 Nov 2017 16:25:03 -0500
Message-ID: <7578.1510867503@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

I wrote:
> Anthony Bykov <a.bykov@postgrespro.ru> writes:
>> 1. In file plpy_exec.c there is a typo on line 347:
>> "... We use the result and resultin[should be here "g"?] variables...

> No, "resultin" is the name of the variable.  Maybe that wasn't a good
> choice of name, though --- do you have a better idea?

After some thought I went with "result_in", which hopefully looks less
like a typo.  Thanks again for reviewing.

			regards, tom lane