From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: "Jonathan S. Katz" <jkatz@postgresql.org>, Noah Misch <noah@leadboat.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>,
        Michael Paquier <michael@paquier.xyz>,
        Justin Pryzby <pryzby@telsasoft.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Shruthi Gowda <gowdashru@gmail.com>
Subject: Re: pg15b2: large objects lost on upgrade
In-reply-to: <YvGxcY6RotGTFSjl@momjian.us>
References: <4152163.1659124804@sss.pgh.pa.us>
 <CA+TgmoY=MfT2uc=N!4sAcHf3_teqYBNtmqVrVYv5oEK=4RfxATw@mail.gmail.com>
 <CA+TgmoZX6Zz4KU2enOYyc+aQWA+S5ZaZRGo6BgxW7mNF4btqaw@mail.gmail.com>
 <125444.1659136594@sss.pgh.pa.us> <20220730054401.GB3644221@rfd.leadboat.com>
 <351616.1659192034@sss.pgh.pa.us>
 <635c8809-3525-7dae-a1a1-0d9069cd86bc@postgresql.org>
 <2657259.1659460333@sss.pgh.pa.us>
 <d0a4f263-a774-394d-134f-4edce6a980e4@postgresql.org>
 <2684751.1659468725@sss.pgh.pa.us> <YvGxcY6RotGTFSjl@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Mon, 08 Aug 2022 20:59:29 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <758595.1660009906.1@sss.pgh.pa.us>
Date: Mon, 08 Aug 2022 21:51:46 -0400
Message-ID: <758596.1660009906@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/758596.1660009906%40sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
>> Hmmm ... now that you mention it, I see nothing in 002_pg_upgrade.pl
>> that attempts to turn off autovacuum on either the source server or
>> the destination.  So one plausible theory is that autovac moved the
>> numbers since we checked.

> Uh, pg_upgrade assumes autovacuum is not running, and tries to enforce
> this:

The problems come from autovac running before or after pg_upgrade.

> Perhaps the test script should do something similar,

I'm not on board with that, for the reasons I gave upthread.

			regards, tom lane