DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references;
	b=VveAPJMWx18KS7UomiF2cOpDSlDgZBcv5VMJ25NByKz8nEZQUL0/Dt5GN2JAt0q+ROcLOxKkvfxCzRSOG5zdLj59VYZwUgsBGyArJm9DX6QYSe0pHAyvYA2mnXzc6wfhC8K2kPhtgubDsHVDXx+4urJ6WXJd7E18A+/Pn8uy3LM=
Message-ID: <758d5e7f050203015316cdabb7@mail.gmail.com>
Date: Thu, 3 Feb 2005 10:53:41 +0100
From: Dawid Kuroczko <qnex42@gmail.com>
Reply-To: Dawid Kuroczko <qnex42@gmail.com>
To: Alvaro Herrera <alvherre@dcc.uchile.cl>
Subject: Re: pg_dump bug in 7.3.9 with sequences
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
In-Reply-To: <20050202220404.GC1967@dcc.uchile.cl>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <42013187.7040806@commandprompt.com>
	<6686.1107379308@sss.pgh.pa.us> <42014C28.1070300@commandprompt.com>
	<20050202220404.GC1967@dcc.uchile.cl>

On Wed, 2 Feb 2005 19:04:04 -0300, Alvaro Herrera
<alvherre@dcc.uchile.cl> wrote:
> > It is not pilot error if PostgreSQL allows it. There is
> > nothing "illegal" about the above commands in their execution.
> > The pg_dump application should recognize that the object has
> > changed and react accordingly.
> 
> ISTM this is a bug, but it's not clear to me what is the solution.
> I can think of two:
> 
> 1. Changing the default is forbidden
> 2. When the default is changed, the dependency on the sequence is
> dropped, and the sequence itself is dropped.

In my humble opinion, the command:
ALTER TABLE ALTER COLUMN fooser SET DEFAULT nextval('aaa_seq');
should be equivalent to:
ALTER TABLE ALTER COLUMN fooser TYPE integer;
ALTER TABLE ALTER COLUMN fooser SET DEFAULT nextval('aaa_seq');

...ie, if we mess with 'default' it is no longer a serial, but a plain
integer with default sequence.

   Regards,
     Dawid