Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ihZkd-0005Sk-5j for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Dec 2019 13:52:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ihZkb-0002wJ-LI for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Dec 2019 13:52:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ihZka-0002wC-Jv for pgsql-hackers@lists.postgresql.org; Wed, 18 Dec 2019 13:52:29 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ihZkV-0000V2-Nb for pgsql-hackers@postgresql.org; Wed, 18 Dec 2019 13:52:28 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id F14AF42D; Wed, 18 Dec 2019 08:52:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 18 Dec 2019 08:52:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=TpLV2b wUxxXP/HRqyvix/4QFOC5N8rNH+ZdUe0cAyMk=; b=SgA/obwYW9TjNNyxMxZIj/ +TluO1GgEcLP88gzBzqYpILk23MpBTbtSCYPBvmwbnIG/4yZVBrVpmdooal21jyl lW7o08p3uBp0zxaKRxyFCGgfdW03h8frAkCMTtjVMY8cPNGtJTvpEfdXZ60muwf6 uYiQ69nwwR0GYxDi3QyYy7RXJbskbMiz/TrXnJkxxXHyC0+rJ3wxgyaeKygPQPzq ylRBm5FMlsd8BtQ/+cwPq5gsfJgr3TfFBg+oP/R6qZ7rPVpJ30ehQVjdkhXrozXl bSb6377LoStSgDdLyq/01HqqV0eTmZssKGl1wAFqNx6yKLcFf0aI0gR/xcb0cBXA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddtledgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffhvfhfohfkffgfgggjtgesmhdtreertdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsedvnhguqh hurggurhgrnhhtrdgtohhmqeenucffohhmrghinhepvdhnughquhgrughrrghnthdrtgho mhenucfkphepleefrddvgedvrdduiedurddufedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehpvghtvghrrdgvihhsvghnthhrrghuthesvdhnughquhgrughrrghnthdrtghomhen ucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from april.pezone.net (p5df2a182.dip0.t-ipconnect.de [93.242.161.130]) by mail.messagingengine.com (Postfix) with ESMTPA id 79B2130600E0; Wed, 18 Dec 2019 08:52:18 -0500 (EST) Subject: Re: Unix-domain socket support on Windows From: Peter Eisentraut To: Andrew Dunstan References: <54bde68c-d134-4eb8-5bd3-8af33b72a010@2ndquadrant.com> <00d4945e-b437-f3b5-f4af-42e99321c846@2ndquadrant.com> <5974caea-1267-7708-40f2-6009a9d653b0@2ndquadrant.com> Cc: pgsql-hackers Organization: 2ndQuadrant Message-ID: <75f72249-8ae6-322a-63df-4fe03eeccb9f@2ndquadrant.com> Date: Wed, 18 Dec 2019 14:52:15 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------E9898E5CCCB90E9901BD178F" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------E9898E5CCCB90E9901BD178F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Next patch: This allows building *with* Unix-domain socket support but *without* a default Unix socket path. This is needed because on Windows we don't have a good default location like "/tmp" and we probably don't want Unix sockets by default at run time so that older Windows versions continue to work out of the box with the same binaries. We have code paths for Unix socket support and no Unix socket support. Now add a third variant: Unix socket support but do not use a Unix socket by default in the client or the server, only if you explicitly specify one. To implement this, tweak things so that setting DEFAULT_PGSOCKET_DIR to "" has the desired effect. This mostly already worked like that; only a few places needed to be adjusted. Notably, the reference to DEFAULT_PGSOCKET_DIR in UNIXSOCK_PATH() could be removed because all callers already resolve an empty socket directory setting with a default if appropriate. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --------------E9898E5CCCB90E9901BD178F Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="v5-0001-Allow-building-without-default-socket-directory.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="v5-0001-Allow-building-without-default-socket-directory.patc"; filename*1="h" RnJvbSAwYjYzYThhNzU4ZDUwNzA5NWJmNTA3MGNlYzgxMTk0MzZjMjY3NTE5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy YXV0Lm9yZz4KRGF0ZTogV2VkLCAxOCBEZWMgMjAxOSAxNDo0NzowNCArMDEwMApTdWJqZWN0 OiBbUEFUQ0ggdjVdIEFsbG93IGJ1aWxkaW5nIHdpdGhvdXQgZGVmYXVsdCBzb2NrZXQgZGly ZWN0b3J5CgpXZSBoYXZlIGNvZGUgcGF0aHMgZm9yIFVuaXggc29ja2V0IHN1cHBvcnQgYW5k IG5vIFVuaXggc29ja2V0IHN1cHBvcnQuCk5vdyBhZGQgYSB0aGlyZCB2YXJpYW50OiBVbml4 IHNvY2tldCBzdXBwb3J0IGJ1dCBkbyBub3QgdXNlIGEgVW5peApzb2NrZXQgYnkgZGVmYXVs dCBpbiB0aGUgY2xpZW50IG9yIHRoZSBzZXJ2ZXIsIG9ubHkgaWYgeW91IGV4cGxpY2l0bHkK c3BlY2lmeSBvbmUuICBUaGlzIHdpbGwgYmUgdXNlZnVsIHdoZW4gd2UgZW5hYmxlIFVuaXgg c29ja2V0IHN1cHBvcnQKb24gV2luZG93cy4KClRvIGltcGxlbWVudCB0aGlzLCB0d2VhayB0 aGluZ3Mgc28gdGhhdCBzZXR0aW5nIERFRkFVTFRfUEdTT0NLRVRfRElSCnRvICIiIGhhcyB0 aGUgZGVzaXJlZCBlZmZlY3QuICBUaGlzIG1vc3RseSBhbHJlYWR5IHdvcmtlZCBsaWtlIHRo YXQ7Cm9ubHkgYSBmZXcgcGxhY2VzIG5lZWRlZCB0byBiZSBhZGp1c3RlZC4gIE5vdGFibHks IHRoZSByZWZlcmVuY2UgdG8KREVGQVVMVF9QR1NPQ0tFVF9ESVIgaW4gVU5JWFNPQ0tfUEFU SCgpIGNvdWxkIGJlIHJlbW92ZWQgYmVjYXVzZSBhbGwKY2FsbGVycyBhbHJlYWR5IHJlc29s dmUgYW4gZW1wdHkgc29ja2V0IGRpcmVjdG9yeSBzZXR0aW5nIHdpdGggYQpkZWZhdWx0IGlm IGFwcHJvcHJpYXRlLgotLS0KIHNyYy9pbmNsdWRlL2xpYnBxL3BxY29tbS5oICAgICAgICB8 ICA2ICsrKy0tLQogc3JjL2luY2x1ZGUvcGdfY29uZmlnX21hbnVhbC5oICAgIHwgIDUgKysr KysKIHNyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLWNvbm5lY3QuYyB8IDE1ICsrKysrKysrKyst LS0tLQogMyBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL2xpYnBxL3BxY29tbS5oIGIvc3JjL2luY2x1 ZGUvbGlicHEvcHFjb21tLmgKaW5kZXggYmFmNmE0YjZjMC4uYTI0YmI3OTZmNCAxMDA2NDQK LS0tIGEvc3JjL2luY2x1ZGUvbGlicHEvcHFjb21tLmgKKysrIGIvc3JjL2luY2x1ZGUvbGli cHEvcHFjb21tLmgKQEAgLTY4LDEwICs2OCwxMCBAQCB0eXBlZGVmIHN0cnVjdAogLyogQ29u ZmlndXJlIHRoZSBVTklYIHNvY2tldCBsb2NhdGlvbiBmb3IgdGhlIHdlbGwga25vd24gcG9y dC4gKi8KIAogI2RlZmluZSBVTklYU09DS19QQVRIKHBhdGgsIHBvcnQsIHNvY2tkaXIpIFwK KwkgICAoQXNzZXJ0TWFjcm8oc29ja2RpciksIFwKKwkJQXNzZXJ0TWFjcm8oKihzb2NrZGly KSAhPSAnXDAnKSwgXAogCQlzbnByaW50ZihwYXRoLCBzaXplb2YocGF0aCksICIlcy8ucy5Q R1NRTC4lZCIsIFwKLQkJCQkoKHNvY2tkaXIpICYmICooc29ja2RpcikgIT0gJ1wwJykgPyAo c29ja2RpcikgOiBcCi0JCQkJREVGQVVMVF9QR1NPQ0tFVF9ESVIsIFwKLQkJCQkocG9ydCkp CisJCQkJIChzb2NrZGlyKSwgKHBvcnQpKSkKIAogLyoKICAqIFRoZSBtYXhpbXVtIHdvcmth YmxlIGxlbmd0aCBvZiBhIHNvY2tldCBwYXRoIGlzIHdoYXQgd2lsbCBmaXQgaW50bwpkaWZm IC0tZ2l0IGEvc3JjL2luY2x1ZGUvcGdfY29uZmlnX21hbnVhbC5oIGIvc3JjL2luY2x1ZGUv cGdfY29uZmlnX21hbnVhbC5oCmluZGV4IDYxYjY2N2QxNjYuLjNiN2NmOGQwYjUgMTAwNjQ0 Ci0tLSBhL3NyYy9pbmNsdWRlL3BnX2NvbmZpZ19tYW51YWwuaAorKysgYi9zcmMvaW5jbHVk ZS9wZ19jb25maWdfbWFudWFsLmgKQEAgLTE5MSw2ICsxOTEsMTEgQEAKICAqIGRpcmVjdG9y eS4gIEJ1dCBpZiB5b3UganVzdCBoYXRlIHRoZSBpZGVhIG9mIHNvY2tldHMgaW4gL3RtcCwK ICAqIGhlcmUncyB3aGVyZSB0byB0d2lkZGxlIGl0LiAgWW91IGNhbiBhbHNvIG92ZXJyaWRl IHRoaXMgYXQgcnVudGltZQogICogd2l0aCB0aGUgcG9zdG1hc3RlcidzIC1rIHN3aXRjaC4K KyAqCisgKiBJZiBzZXQgdG8gYW4gZW1wdHkgc3RyaW5nLCB0aGVuIEFGX1VOSVggc29ja2V0 cyBhcmUgbm90IHVzZWQgYnkgZGVmYXVsdC4gIEEKKyAqIHNlcnZlciB3aWxsIG5vdCBjcmVh dGUgYW4gQUZfVU5JWCBzb2NrZXQgdW5sZXNzIHRoZSBydW4tdGltZSBjb25maWd1cmF0aW9u CisgKiBpcyBjaGFuZ2VkOyBhIGNsaWVudCB3aWxsIGNvbm5lY3QgdmlhIFRDUC9JUCBieSBk ZWZhdWx0IGFuZCB3aWxsIG9ubHkgdXNlCisgKiBhbiBBRl9VTklYIHNvY2tldCBpZiBvbmUg aXMgZXhwbGljaXRseSBzcGVjaWZpZWQuCiAgKi8KICNkZWZpbmUgREVGQVVMVF9QR1NPQ0tF VF9ESVIgICIvdG1wIgogCmRpZmYgLS1naXQgYS9zcmMvaW50ZXJmYWNlcy9saWJwcS9mZS1j b25uZWN0LmMgYi9zcmMvaW50ZXJmYWNlcy9saWJwcS9mZS1jb25uZWN0LmMKaW5kZXggM2Nh N2UwNTYwYy4uMTk4ZWNiYzA0MCAxMDA2NDQKLS0tIGEvc3JjL2ludGVyZmFjZXMvbGlicHEv ZmUtY29ubmVjdC5jCisrKyBiL3NyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLWNvbm5lY3QuYwpA QCAtMTA3OSwxMiArMTA3OSwxNyBAQCBjb25uZWN0T3B0aW9uczIoUEdjb25uICpjb25uKQog CQkJaWYgKGNoLT5ob3N0KQogCQkJCWZyZWUoY2gtPmhvc3QpOwogI2lmZGVmIEhBVkVfVU5J WF9TT0NLRVRTCi0JCQljaC0+aG9zdCA9IHN0cmR1cChERUZBVUxUX1BHU09DS0VUX0RJUik7 Ci0JCQljaC0+dHlwZSA9IENIVF9VTklYX1NPQ0tFVDsKLSNlbHNlCi0JCQljaC0+aG9zdCA9 IHN0cmR1cChEZWZhdWx0SG9zdCk7Ci0JCQljaC0+dHlwZSA9IENIVF9IT1NUX05BTUU7CisJ CQlpZiAoREVGQVVMVF9QR1NPQ0tFVF9ESVJbMF0pCisJCQl7CisJCQkJY2gtPmhvc3QgPSBz dHJkdXAoREVGQVVMVF9QR1NPQ0tFVF9ESVIpOworCQkJCWNoLT50eXBlID0gQ0hUX1VOSVhf U09DS0VUOworCQkJfQorCQkJZWxzZQogI2VuZGlmCisJCQl7CisJCQkJY2gtPmhvc3QgPSBz dHJkdXAoRGVmYXVsdEhvc3QpOworCQkJCWNoLT50eXBlID0gQ0hUX0hPU1RfTkFNRTsKKwkJ CX0KIAkJCWlmIChjaC0+aG9zdCA9PSBOVUxMKQogCQkJCWdvdG8gb29tX2Vycm9yOwogCQl9 Ci0tIAoyLjI0LjEKCg== --------------E9898E5CCCB90E9901BD178F--