Message-ID: <760ee97a-e336-4d7b-9477-9d9e99370097@postgrespro.ru>
Date: Fri, 24 Nov 2023 10:52:25 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)
Content-Language: en-US
To: Damir Belyalov <dam.bel07@gmail.com>, zhihuifan1213@163.com
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>,
 torikoshia <torikoshia@oss.nttdata.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Andres Freund <andres@anarazel.de>, anisimow.d@gmail.com, HukuToc@gmail.com,
 Alena Rybakina <lena.ribackina@yandex.ru>, pgsql-hackers@lists.postgresql.org
References: <483E1B59-4A80-450B-8685-7CC12762FD5A@anarazel.de>
 <9a94e684d6528dff74de5959e97032f3@oss.nttdata.com>
 <8e5c596e47435e3b37b7a751ebcd9569@oss.nttdata.com>
 <20230322175000.qbdctk7bnmifh5an@awork3.anarazel.de>
 <16e09747fcfbb21c30e4c1009c416aa4@oss.nttdata.com>
 <19551e8c2717c24689913083f841ddb5@oss.nttdata.com>
 <CALH1LguOY-VvJBWvjpLR2W3t0Z2p=LGSK5tzLrKwtzZ2UsqwGg@mail.gmail.com>
 <43399b33fe573f0548410893f41f84b6@oss.nttdata.com>
 <CALH1LgseNT7mxpGzQsQwOJz_UwYBo6L-4vR9tmJqb-WNPkt6Bg@mail.gmail.com>
 <8de9d5e1-2f81-ee2e-ece4-b1a6ede1f285@yandex.ru>
 <b74c1c3e3cc1c5d7ad5fb527b27d2b60@oss.nttdata.com>
 <c0fb57b82b150953f26a5c7e340412e8@oss.nttdata.com>
 <CALH1Lgtg39crESw644KDH+ejBWuW3Vospe67F-ZWXNeBMEE=PA@mail.gmail.com>
 <58fa3b63e88ffd0a09273e38aec0661e@oss.nttdat!>
 <B082C6BE-D2F2-4DD4-8649-E81E24A6840E@yesql.se>
 <752672.1699474336@sss.pgh.pa.us> <878r77mtlt.fsf@163.com>
 <CALH1LgueaSXWJ=eZ-0-LYCm8tF45SoOM0QFc55C-xpbGfNkFyg@mail.gmail.com>
From: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Organization: Postgres Professional
In-Reply-To: <CALH1LgueaSXWJ=eZ-0-LYCm8tF45SoOM0QFc55C-xpbGfNkFyg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/760ee97a-e336-4d7b-9477-9d9e99370097%40postgrespro.ru>
Precedence: bulk

On 14/11/2023 17:10, Damir Belyalov wrote:
>       Here is a very straw-man-level sketch of what I think might work.
>       The option to COPY FROM looks something like
> 
>            ERRORS TO other_table_name (item [, item [, ...]])
> 
> 
> I tried to implement the patch using a table and came across a number of 
> questions.
> 
> Which table should we implement for this feature: a system catalog table 
> or store this table as a file or create a new table?
> 
> In these cases, security and user rights management issues arise.
> It is better for other users not to see error lines from another user. 
> It is also not clear how access rights to this table are inherited and 
> be given.

Previous reviews have given helpful ideas about storing errors in the 
new table.
It should be trivial code - use the current table name + 'err' + suffix 
as we already do in the case of conflicting auto-generated index names.
The 'errors table' must inherit any right policies from the table, to 
which we do the copy.

-- 
regards,
Andrei Lepikhov
Postgres Professional