Message-ID: <76202fae-0c34-4f49-e3a0-1071c3fcf9e1@enterprisedb.com>
Date: Tue, 22 Feb 2022 21:12:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: postgres_fdw: using TABLESAMPLE to collect remote sample
Content-Language: en-US
To: Fujii Masao <masao.fujii@oss.nttdata.com>,
 Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <151e835f-55d6-ddbc-b5b4-07ee606aba44@enterprisedb.com>
 <2080021.1644601183@sss.pgh.pa.us>
 <CA+TgmoYx596-mqUP=xf0DdQ97UERxXfzhR0Otpa411sGV1vKow@mail.gmail.com>
 <2082308.1644602761@sss.pgh.pa.us>
 <CA+TgmobqyX6s2VQ0=HGZc4xW+tOusPa0FLfSevH_PA2Kum34BA@mail.gmail.com>
 <60c4dc7c-82e8-ab04-a938-d7b7c5ee75f0@enterprisedb.com>
 <84afe85f-2aa0-5aef-fa4a-59759afc03fb@enterprisedb.com>
 <ac2fb459-3def-6a7c-afce-46ebe5f66575@oss.nttdata.com>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <ac2fb459-3def-6a7c-afce-46ebe5f66575@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/76202fae-0c34-4f49-e3a0-1071c3fcf9e1%40enterprisedb.com>
Precedence: bulk

On 2/22/22 01:36, Fujii Masao wrote:
> 
> 
> On 2022/02/18 22:28, Tomas Vondra wrote:
>> Hi,
>>
>> here's a slightly updated version of the patch series.
> 
> Thanks for updating the patches!
> 
> 
>> The 0001 part
>> adds tracking of server_version_num, so that it's possible to enable
>> other features depending on it.
> 
> Like configure_remote_session() does, can't we use PQserverVersion()
> instead of implementing new function GetServerVersion()?
> 

Ah! My knowledge of libpq is limited, so I wasn't sure this function
exists. It'll simplify the patch.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company