MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 18 Oct 2023 15:50:39 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Alexander Kukushkin <cyberdemn@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, michael@paquier.xyz,
 pgsql-hackers@postgresql.org, bungina@gmail.com,
 pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind WAL segments deletion pitfall
In-Reply-To: 
 <CAFh8B=kqWWmMKT6T6Hea2d1PvBHsSOXBformB7Dr09GWEOOkLw@mail.gmail.com>
References: <8b385bb6d5f87e54c1c6333fece0444a@oss.nttdata.com>
 <ZORIVnxs+lXoEAQG@paquier.xyz>
 <CAFh8B=k2DUwruBA3djsMf3b_wfqeN092iqaDcZYJ4PAgnne2KA@mail.gmail.com>
 <20230824.094538.2107929879048686192.horikyota.ntt@gmail.com>
 <bb706f8393c5207812268a5a2e3f98d7@oss.nttdata.com>
 <CAFh8B=m0TuTNyPzOC6zWrVH2iOEnuNyuPSazqTgjVbd=nt3B2Q@mail.gmail.com>
 <CAFh8B=kqWWmMKT6T6Hea2d1PvBHsSOXBformB7Dr09GWEOOkLw@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <763cac924055f1669578bea950c667c7@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/763cac924055f1669578bea950c667c7%40oss.nttdata.com>
Precedence: bulk

Thanks for the patch.

I tested the v6 patch using the test script attached on [1], old primary 
has succeeded to become new standby.

I have very minor questions on the regression tests mainly regarding the 
consistency with other tests for pg_rewind:


> +setup_cluster;
> +create_standby;

Would it be better to add parentheses?
Also should we add "RewindTest::" for these function?


> +primary_psql("create table t(a int)");
> +primary_psql("insert into t values(0)");
> +primary_psql("select pg_switch_wal()");
..

Should 'select', 'create', etc be capitalized?


> my $false = "$^X -e 'exit(1)'";
I feel it's hard to understand what does this mean.
Isn't it better to add comments and describe this is for windows 
environments?


-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation