public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrei Lepikhov <[email protected]>
To: wenhui qiu <[email protected]>
To: Richard Guo <[email protected]>
Cc: David Rowley <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Memoize ANTI and SEMI JOIN inner
Date: Wed, 2 Jul 2025 11:01:39 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAGjGUAL+GcLFGh0117xGcXk1jXyhM7ShNxnaoV3vUH8PyO654g@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CAApHDvr2NRbjLXEUXvvKNCDcHfhC6UBL6ZmJzXZ29MBPi3+y8g@mail.gmail.com>
<CAMbWs4-czfhkn+RaA8RXL-sf+NZXDZ8fOYbTOytyY6KbVGz+mQ@mail.gmail.com>
<CAApHDvqcuPQoSR+LPtpDOT5vVWj0LS0d0ZaqfJ1U3d+c4ieTdA@mail.gmail.com>
<CAMbWs48FdLiMNrmJL-g6mDvoQVt0yNyJAqMkv4e2Pk-5GKCZLA@mail.gmail.com>
<CAMbWs4_pDZYK+2RGTTjsyoRkRe+Y9rT3Y6b3XtuzcPkNTeP-zw@mail.gmail.com>
<CAGjGUAL+GcLFGh0117xGcXk1jXyhM7ShNxnaoV3vUH8PyO654g@mail.gmail.com>
On 2/7/2025 05:48, wenhui qiu wrote:
> HI
>
> > - if (!extra->inner_unique && (jointype == JOIN_SEMI ||
> > - jointype == JOIN_ANTI))
> > + if ((jointype == JOIN_SEMI || jointype == JOIN_ANTI) &&
> > + !extra->inner_unique)
> To be nitpicky, this change is meant to align with the earlier comment
> modifications to improve code readability, right? Everything else looks
> good to me."
Yep, I also found only this flaw.
Comments looks clear to me, test is quite stable.
May be correct the line:
INSERT INTO tab_anti SELECT i%3, false FROM generate_series(1,100)i;
with a backspace or an 'AS' keyword?
--
regards, Andrei Lepikhov
view thread (26+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Memoize ANTI and SEMI JOIN inner
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox