Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEQYC-0007h5-0P for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Jun 2023 08:29:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qEQYA-0003Lb-VE for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Jun 2023 08:29:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEQYA-0003LS-Lc for pgsql-hackers@lists.postgresql.org; Wed, 28 Jun 2023 08:29:18 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qEQY8-000wBC-Ao for pgsql-hackers@lists.postgresql.org; Wed, 28 Jun 2023 08:29:18 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id B46332F929E8 for ; Wed, 28 Jun 2023 10:29:15 +0200 (CEST) Received: from s979.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id A47812E2803A; Wed, 28 Jun 2023 10:29:15 +0200 (CEST) Received: from s473.loopia.se (unknown [172.22.191.5]) by s979.loopia.se (Postfix) with ESMTP id A0F6F10BC45B; Wed, 28 Jun 2023 10:29:15 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s934.loopia.se ([172.22.191.6]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with UTF8LMTP id vUTrV5iirQZs; Wed, 28 Jun 2023 10:29:14 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id D0AFF7CEA65; Wed, 28 Jun 2023 10:29:14 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames From: Daniel Gustafsson In-Reply-To: <20230531190743.nzktxombkupb25ud@c19> Date: Wed, 28 Jun 2023 10:29:14 +0200 Cc: Postgres hackers , Mat Arye , Regina Obe , Yurii Rashkovskii , Tom Lane , Regina Obe Content-Transfer-Encoding: 7bit Message-Id: <766065FF-B834-4272-ADE8-559DB06FF9E7@yesql.se> References: <55512.1673304709@sss.pgh.pa.us> <20230409204629.sf4fptx672iehcau@c19> <000501d96c23$0f05bdf0$2d1139d0$@pcorp.us> <20230411184823.s3cctaf63qvfeqlj@c19> <006201d96cb5$3d23b150$b76b13f0$@pcorp.us> <20230411212737.phtzffycglbdhmpx@c19> <002201d96e57$e50461a0$af0d24e0$@pcorp.us> <20230427104957.knkkt3klh5uabzke@c19> <20230531190743.nzktxombkupb25ud@c19> To: Sandro Santilli X-Mailer: Apple Mail (2.3696.120.41.1.3) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 31 May 2023, at 21:07, Sandro Santilli wrote: > On Thu, Apr 27, 2023 at 12:49:57PM +0200, Sandro Santilli wrote: >> I'm happy to bring back the control-file switch if there's an >> agreement about that. > > I'm attaching an up-to-date version of the patch with the control-file > switch back in, so there's an explicit choice by extension developers. This version fails the extension test since the comment from the .sql file is missing from test_extensions.out. Can you fix that in a rebase such that the CFBot can have a green build of this patch? -- Daniel Gustafsson