Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tGJJ5-0029s0-JP for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Nov 2024 14:46:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tGJJ4-00FNwK-CO for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Nov 2024 14:46:18 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tGJIK-00FL3O-48 for pgsql-hackers@lists.postgresql.org; Wed, 27 Nov 2024 14:45:32 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tGJIH-004Ali-4f for pgsql-hackers@postgresql.org; Wed, 27 Nov 2024 14:45:30 +0000 Received: from [192.168.11.4] (p3899254-ipxg13401funabasi.chiba.ocn.ne.jp [118.22.72.254]) by oss.nttdata.com (Postfix) with ESMTPSA id A194261A60; Wed, 27 Nov 2024 23:45:24 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at oss.nttdata.com Message-ID: <766300e6-b95b-4e82-b815-c55c6d16dc77@oss.nttdata.com> Date: Wed, 27 Nov 2024 23:45:23 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Add reject_limit option to file_fdw Content-Language: en-US To: torikoshia Cc: Yugo NAGATA , Pgsql Hackers References: <54747389a562688eab7077b144daff6a@oss.nttdata.com> <2b3ad6d4-e05f-4188-8cfe-1fd9d949a9c9@oss.nttdata.com> <192ede1e4c2b34b853e5ac46f8dee50b@oss.nttdata.com> <20241112145114.ba288defc684699bf8646942@sraoss.co.jp> <2f03bf95556c4c41d6b1659e74b346c7@oss.nttdata.com> <20241113231706.09e5b5ea9640289312835be8@sraoss.co.jp> <336dd0aa-f91b-4953-b0a0-b87215c571d2@oss.nttdata.com> From: Fujii Masao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024/11/21 15:43, torikoshia wrote: > Thanks for the update! Agreed. > I think the validator tests related to the on_error option you added are sufficient. I've pushed the patch. Thanks! > As for the other file_fdw options, I'm a bit concerned whether it would be better to add validator tests for cases like when 'encoding' is 'unsupported', but that should be discussed in another thread. I'm not sure how valuable it is to add that test, but yes, it would be better to start a new thread for discussion if needed. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION