Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6h5r-0003Ah-7P for pgsql-hackers@arkaria.postgresql.org; Fri, 05 May 2017 17:32:39 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d6h5p-0003Hu-8v for pgsql-hackers@arkaria.postgresql.org; Fri, 05 May 2017 17:32:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d6h5n-0003Fm-L0 for pgsql-hackers@postgresql.org; Fri, 05 May 2017 17:32:35 +0000 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d6h5j-0000zB-Jv for pgsql-hackers@postgresql.org; Fri, 05 May 2017 17:32:34 +0000 Received: by mail-wm0-x234.google.com with SMTP id w64so29854652wma.0 for ; Fri, 05 May 2017 10:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=YL3CmuCymfn0fmUOVYGKWT0V9+cH4uSuFiyHkNYQHDI=; b=cGX5TpZkL40epHrr3OG88CsAfUw8xhDEGgUcKiWCl9zIgUdxlReNbpjsq5VXo0GDEo QIOkGiSpkFDLYyqX8w7a7N6CEl6LUmsLkEkGdzPdOR0tQYRAGp/Fu1xKYzmNAlwpteem GrNrCL0nYRjaeziV28CwQ45+GDAgD2cVYbNNHDYEfoLnt36rXD0KicMq1EVHnspG4FBM L/y0mXgXNnTjHxKHmsV4/7PlCd2+DbFxYd2V+cww3faDJPpHTin+2pFB0e+E4/JXVNzn qaMfRIGO6S6Fuf3ObiD/bFpHN/XO+ntQ886T8rcEzxwXDjyglWj70ooW9eBuwe+jblEb j9aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=YL3CmuCymfn0fmUOVYGKWT0V9+cH4uSuFiyHkNYQHDI=; b=LjK9QHPB8vCw9Y4yyXllUEZ89PyXYQLnAGqGWQVwH8809yQrks0/YyGpnjM+DCxwqE b88cOo+TRa7txcQOaLDTpiswy1Diq/eKjpqjza+rkgRscmWQ3TwEQINoGHbq22XBfhPJ N+cTuIpspPJGFiFy8lOpGa8oxCpGl4gstuR3VmcAJjVbNyzVuZW8JxmkLoCopCU13zvC q1foxncrh2VOE3kOB/28c8wr791sd4vPOn65/2t8BrVVO2epqATIyI0ccVuHJ2CA+O+L D4mC9jdN2slEUkyWykNsB4U8EOI2zBCcaiHVkgbhK4XBfweDTgN9hDPX/wYob3iRudgy T67A== X-Gm-Message-State: AN3rC/7yFVroQ8k5b4inHUy3aLFgkmW1eOn+aDtCVpCENBydXU4Dgiw0 Uools/N7p/Nm/xv9 X-Received: by 10.28.15.14 with SMTP id 14mr6321254wmp.106.1494005549928; Fri, 05 May 2017 10:32:29 -0700 (PDT) Received: from [192.168.0.105] (150.123.broadband11.iol.cz. [90.178.123.150]) by smtp.gmail.com with ESMTPSA id h199sm2202512wme.4.2017.05.05.10.32.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 May 2017 10:32:29 -0700 (PDT) Subject: Re: snapbuild woes To: Andres Freund References: <20170501005921.qcqd7w2njpv3av6s@alap3.anarazel.de> <20170501013529.sejtgo2acxbvq26q@alap3.anarazel.de> <209861fc-718f-0a7b-3a1d-36512865c209@2ndquadrant.com> <20170501080348.vb6mj5whdex3f7l7@alap3.anarazel.de> <20170501191419.coqbtx2jodu22ufz@alap3.anarazel.de> <20170505000004.gihrtl7bhxeolf3q@alap3.anarazel.de> <20170505004237.edtahvrwb3uwd5rs@alap3.anarazel.de> <316d270d-d97e-65ba-dcdd-34f6b13698f6@2ndquadrant.com> <20170505161852.vmjwhmum2zoar2xk@alap3.anarazel.de> Cc: PostgreSQL-development , Erik Rijkers , Robert Haas , Craig Ringer From: Petr Jelinek Message-ID: <76657a2c-ff2c-e328-9df6-6897dbe1a011@2ndquadrant.com> Date: Fri, 5 May 2017 19:32:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170505161852.vmjwhmum2zoar2xk@alap3.anarazel.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 05/05/17 18:18, Andres Freund wrote: > On 2017-05-05 13:53:16 +0200, Petr Jelinek wrote: >> On 05/05/17 02:42, Andres Freund wrote: >>> On 2017-05-04 17:00:04 -0700, Andres Freund wrote: >>>> Attached is a prototype patch for that. >>> >> >> I am not sure I understand the ABI comment for started_collection_at. >> What's the ABI issue? The struct is private to snapbuild.c module. Or >> you want to store it in the ondisk snapshot as well? > > It's stored on-disk already :( Hmm okay, well then I guess we'll have to store it somewhere inside running, we should not normally care about that since we only load CONSISTENT snapshots where running don't matter anymore. Alternatively we could bump the SNAPBUILD_VERSION but that would make it impossible to downgrade minor version which is bad (I guess we'll want to do that for master, but not back-branches). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers