From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Richard Guo <guofenglinux@gmail.com>, David Rowley <dgrowleyml@gmail.com>,
        jian he <jian.universality@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail.
In-reply-to: <1e6ca7b3-98e6-46b2-9982-97f92c7523d8@dunslane.net>
References: <CACJufxFVQmr4=JWHAOSLuKA5Zy9H26nY6tVrRFBOekHoALyCkQ@mail.gmail.com> <CAApHDvpBMSGhXVeFdw_qmjPqU5yHvJJ7k0z7kD069EC4di2Pag@mail.gmail.com> <CAMbWs4-iYKxrMs8kj+49gVA4X1_=PYAaw5HL_3g_yVXpAHzYww@mail.gmail.com> <1e6ca7b3-98e6-46b2-9982-97f92c7523d8@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Tue, 07 May 2024 08:00:25 -0400"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <76886.1715106032.0@sss.pgh.pa.us>
Date: Tue, 07 May 2024 14:20:55 -0400
Message-ID: <76910.1715106055@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/76910.1715106055%40sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <76886.1715106032.1@sss.pgh.pa.us>

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2024-05-07 Tu 06:05, Richard Guo wrote:
>> +1 to have build farm coverage of REALLOCATE_BITMAPSETS. This flag
>> seems quite useful.

> I have added it to the CPPFLAGS on prion.

... and as expected, prion fell over.

I find that Richard's proposed fix makes the core regression tests
pass, but we still fail check-world.  So I'm afraid we need something
more aggressive, like the attached which makes make_restrictinfo
copy all its input bitmapsets.  Without that, we still have sharing
of bitmapsets across different RestrictInfos, which seems pretty
scary given what we now see about the effects of 00b41463c.  This
seems annoyingly expensive, but maybe there's little choice?

Given this, we could remove ad-hoc bms_copy calls from the callers
of make_restrictinfo, distribute_quals_to_rels, etc.  I didn't go
looking for possible wins of that sort; there's unlikely to be a
lot of them.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff;
	name="copy-bitmapsets-when-making-restrictinfos.patch";
	charset="us-ascii"
Content-ID: <76886.1715106032.2@sss.pgh.pa.us>
Content-Description: copy-bitmapsets-when-making-restrictinfos.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/src/backend/optimizer/util/restrictinfo.c b/src/backend/optim=
izer/util/restrictinfo.c
index 0b406e9334..e81861bc8b 100644
--- a/src/backend/optimizer/util/restrictinfo.c
+++ b/src/backend/optimizer/util/restrictinfo.c
@@ -132,8 +132,8 @@ make_restrictinfo_internal(PlannerInfo *root,
 	restrictinfo->is_clone =3D is_clone;
 	restrictinfo->can_join =3D false; /* may get set below */
 	restrictinfo->security_level =3D security_level;
-	restrictinfo->incompatible_relids =3D incompatible_relids;
-	restrictinfo->outer_relids =3D outer_relids;
+	restrictinfo->incompatible_relids =3D bms_copy(incompatible_relids);
+	restrictinfo->outer_relids =3D bms_copy(outer_relids);
 =

 	/*
 	 * If it's potentially delayable by lower-level security quals, figure o=
ut
@@ -191,7 +191,7 @@ make_restrictinfo_internal(PlannerInfo *root,
 =

 	/* required_relids defaults to clause_relids */
 	if (required_relids !=3D NULL)
-		restrictinfo->required_relids =3D required_relids;
+		restrictinfo->required_relids =3D bms_copy(required_relids);
 	else
 		restrictinfo->required_relids =3D restrictinfo->clause_relids;
 =


------- =_aaaaaaaaaa0--