Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQa4s-00022o-8w for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 20:00:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oQa4r-0002ol-4P for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 20:00:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQa4q-0002ob-RS for pgsql-hackers@lists.postgresql.org; Tue, 23 Aug 2022 20:00:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQa4o-0000iu-2F for pgsql-hackers@lists.postgresql.org; Tue, 23 Aug 2022 20:00:43 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 27NK0aru769713; Tue, 23 Aug 2022 16:00:36 -0400 From: Tom Lane To: Andrew Dunstan cc: "Jonathan S. Katz" , Andres Freund , Robert Haas , Nikita Glukhov , PostgreSQL Hackers , Michael Paquier , John Naylor , Amit Langote Subject: Re: SQL/JSON features for v15 In-reply-to: References: <20220815223853.itrlpqgpqheg6r6a@awork3.anarazel.de> <225d341b-f310-eed0-ceff-b8ec61669d9f@postgrespro.ru> <20220816021425.5sa6gx67zmpou3bc@awork3.anarazel.de> <8d0ffc54-469a-ffab-68a3-8b547e24a08d@postgresql.org> <7d83684b-7932-9f29-400b-0beedfafcdd4@postgrespro.ru> <69022273-e7e3-6d1a-10f8-d1b4740e4b97@postgresql.org> <92cab50c-152b-84fc-fd49-12b936113a3d@postgresql.org> <692364.1661267311@sss.pgh.pa.us> <35468585-e18f-3be6-a228-4ec478f796ac@postgresql.org> <20220823172617.4oxozbuu7eeprcmh@awork3.anarazel.de> <78040b98-83c8-7eb0-54c0-24ce48c487d9@postgresql.org> Comments: In-reply-to Andrew Dunstan message dated "Tue, 23 Aug 2022 15:45:01 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <769711.1661284836.1@sss.pgh.pa.us> Date: Tue, 23 Aug 2022 16:00:36 -0400 Message-ID: <769712.1661284836@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > On 2022-08-23 Tu 15:32, Jonathan S. Katz wrote: >> On 8/23/22 1:26 PM, Andres Freund wrote: >>> We could decide to revert this for 15, but leave it in tree for HEAD. >> If it comes to that, I think that is a reasonable suggestion so long >> as we're committed to making the requisite changes. I'm not particularly on board with that. In the first place, I'm unconvinced that very much of the current code will survive, and I don't want people contorting the rewrite in order to salvage committed code that would be better off junked. In the second place, if we still don't have a shippable feature in a year, then undoing it again is going to be just that much harder. > One good reason for this is that way we're not fighting against the node > changes, which complicate any reversion significantly. Having said that, I'm prepared to believe that a lot of the node infrastructure won't change because it's dictated by the SQL-spec grammar. So we could leave that part alone in HEAD; at worst it adds some dead code in backend/nodes. regards, tom lane