Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rZd56-005ZEW-Tn for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Feb 2024 20:39:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rZd55-00D3rE-Tc for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Feb 2024 20:39:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rZd55-00D3r6-HA for pgsql-hackers@lists.postgresql.org; Mon, 12 Feb 2024 20:39:11 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rZd53-006rq5-Dv for pgsql-hackers@lists.postgresql.org; Mon, 12 Feb 2024 20:39:10 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 40D6B2FDD15F for ; Mon, 12 Feb 2024 21:39:08 +0100 (CET) Received: from s934.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 2FC182E3107F; Mon, 12 Feb 2024 21:39:08 +0100 (CET) Received: from s473.loopia.se (unknown [172.22.191.6]) by s934.loopia.se (Postfix) with ESMTP id 2DC787CEA3A; Mon, 12 Feb 2024 21:39:08 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.21 X-Spam-Level: X-Spam-Status: No, score=-1.21 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=disabled Authentication-Results: s473.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s899.loopia.se ([172.22.191.5]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with LMTP id bks5E_EWVJwy; Mon, 12 Feb 2024 21:39:07 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s899.loopia.se (Postfix) with ESMTPSA id E1E972C8BA8E; Mon, 12 Feb 2024 21:39:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1707770347; bh=F43eBywBWPVuzPgyQw+tLo3IRU1AuToG/c83joJa25E=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=uIxS5g7u4HEofcaF7KFRd0n18fn1E4IuiZ7VEorc0Ix2DKUCB5l7VXvC2FL+ty1iz MrmM+RK//3r5LAmgOeKfaJOHecN7xUT3YbqPE6qulbbyN/qMhZ++qOU1Y6b2ynGPGE zBpjFXzX3GpUO3jDW7lOY6vcZJUTC1UX8nNeyw+Nt3nSrrVuGiTi7O5rGybklPO/LR Ln9oxlIUzx1UfaqebefwWREYP5IDjxSl+WrxS+aC9K7GEqvW4tb9t8FYaU4xqZ1PI/ mRh/Dle6vJYaF3s8BVYrn83AXWkIH618iEnRHmAYy8DKDwrNCLU1zmBmwGkvcp69qS a0+OB/rra/6Tw== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: Fix a typo in pg_rotate_logfile From: Daniel Gustafsson In-Reply-To: Date: Mon, 12 Feb 2024 21:39:06 +0100 Cc: PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <772E8FE1-B1F7-4472-A132-06498B9D6907@yesql.se> References: To: Bharath Rupireddy X-Mailer: Apple Mail (2.3696.120.41.1.4) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 12 Feb 2024, at 21:32, Bharath Rupireddy = wrote: > I happened to notice a typo in pg_rotate_logfile in ipc/signalfuncs.c > - the hint message wrongly mentions that pg_logfile_rotate is part of > the core; which is actually not. pg_logfile_rotate is an adminpack's > 1.0 SQL function dropped in 2.0. The core defines pg_rotate_logfile > SQL function instead, so use that. Here's a patch to fix the typo. Nice catch! This needs to be backpatched all the way down to 12 as that function wen't away a long time ago (it was marked as deprecated all the = way back in 9.1). -- Daniel Gustafsson